Paths

Table of Contentst

-
services/identity/src/
-
identity/
-
src/
-
client_service.rs
-
shared/protos/
-
protos/
-
identity_client.proto

[identity] log out user RPC
ClosedPublic
Actions

Authored by varun on Jul 14 2023, 1:01 PM.

Details

Reviewers

• jon
bartek

Commits

rCOMM10f3533bf22d: [identity] log out user RPC

Summary

calling this RPC will clear a device's access token and keys from DDB

Depends on D8500

Test Plan

called the RPC from kreya and verified that my device's keys and token were removed from DDB

Diff Detail

Repository

rCOMM Comm

Branch

logout (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Jul 14 2023, 1:01 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 14 2023, 1:01 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 14 2023, 1:06 PM

Harbormaster failed remote builds in B20936: Diff 28690!

trigger CI

Harbormaster completed remote builds in B21044: Diff 28840.Jul 19 2023, 8:40 AM

varun requested review of this revision.Jul 19 2023, 8:40 AM

Eventually, we should move this to the authenticated service

services/identity/src/client_service.rs
689–706 ↗	(On Diff #28840)	feel like this should just be a call to `verify_access_token`

This revision now requires changes to proceed.Jul 19 2023, 12:19 PM

addressed feedback. found a few other instances where we could simplify logic by calling verify_access_token

Harbormaster completed remote builds in B21738: Diff 29873.Aug 14 2023, 12:18 PM

Accepting to not block progress.

Eventually this should be moved to the authenticated proto, however, that can wait until after https://phab.comm.dev/D8804 lands.

This revision is now accepted and ready to land.Aug 15 2023, 9:42 AM

Closed by commit rCOMM10f3533bf22d: [identity] log out user RPC (authored by varun). · Explain WhyAug 15 2023, 9:50 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM10f3533bf22d: [identity] log out user RPC.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

client_service.rs

50 lines

shared/

protos/

identity_client.proto

12 lines

Diff 28690

View Options

services/identity/src/client_service.rs

// @flow		// @flow

import type { Utility as OlmUtility } from '@commapp/olm';		import type { Utility as OlmUtility } from '@commapp/olm';
import invariant from 'invariant';		import invariant from 'invariant';
import { ErrorTypes, SiweMessage } from 'siwe';		import { ErrorTypes, SiweMessage } from 'siwe';
import t from 'tcomb';		import t, { type TInterface } from 'tcomb';
import bcrypt from 'twin-bcrypt';		import bcrypt from 'twin-bcrypt';

import { baseLegalPolicies, policies } from 'lib/facts/policies.js';		import {
		baseLegalPolicies,
		policies,
		policyTypeValidator,
		} from 'lib/facts/policies.js';
import { hasMinCodeVersion } from 'lib/shared/version-utils.js';		import { hasMinCodeVersion } from 'lib/shared/version-utils.js';
import type {		import type {
ResetPasswordRequest,		ResetPasswordRequest,
LogOutResponse,		LogOutResponse,
DeleteAccountRequest,		DeleteAccountRequest,
RegisterResponse,		RegisterResponse,
RegisterRequest,		RegisterRequest,
LogInResponse,		LogInResponse,
Show All 10 Lines
import type {		import type {
ClientAvatar,		ClientAvatar,
UpdateUserAvatarRequest,		UpdateUserAvatarRequest,
} from 'lib/types/avatar-types.js';		} from 'lib/types/avatar-types.js';
import type {		import type {
IdentityKeysBlob,		IdentityKeysBlob,
SignedIdentityKeysBlob,		SignedIdentityKeysBlob,
} from 'lib/types/crypto-types.js';		} from 'lib/types/crypto-types.js';
import type { CalendarQuery } from 'lib/types/entry-types.js';		import {
import { defaultNumberPerThread } from 'lib/types/message-types.js';		type CalendarQuery,
		rawEntryInfoValidator,
		} from 'lib/types/entry-types.js';
		import {
		defaultNumberPerThread,
		rawMessageInfoValidator,
		messageTruncationStatusesValidator,
		} from 'lib/types/message-types.js';
import type {		import type {
SIWEAuthRequest,		SIWEAuthRequest,
SIWEMessage,		SIWEMessage,
SIWESocialProof,		SIWESocialProof,
} from 'lib/types/siwe-types.js';		} from 'lib/types/siwe-types.js';
import type {		import type {
SubscriptionUpdateRequest,		SubscriptionUpdateRequest,
SubscriptionUpdateResponse,		SubscriptionUpdateResponse,
} from 'lib/types/subscription-types.js';		} from 'lib/types/subscription-types.js';
import type { PasswordUpdate } from 'lib/types/user-types.js';		import { rawThreadInfoValidator } from 'lib/types/thread-types.js';
		import {
		type PasswordUpdate,
		loggedOutUserInfoValidator,
		loggedInUserInfoValidator,
		oldLoggedInUserInfoValidator,
		userInfoValidator,
		} from 'lib/types/user-types.js';
import { updateUserAvatarRequestValidator } from 'lib/utils/avatar-utils.js';		import { updateUserAvatarRequestValidator } from 'lib/utils/avatar-utils.js';
import {		import {
identityKeysBlobValidator,		identityKeysBlobValidator,
signedIdentityKeysBlobValidator,		signedIdentityKeysBlobValidator,
} from 'lib/utils/crypto-utils.js';		} from 'lib/utils/crypto-utils.js';
import { ServerError } from 'lib/utils/errors.js';		import { ServerError } from 'lib/utils/errors.js';
import { values } from 'lib/utils/objects.js';		import { values } from 'lib/utils/objects.js';
import { promiseAll } from 'lib/utils/promises.js';		import { promiseAll } from 'lib/utils/promises.js';
import {		import {
getPublicKeyFromSIWEStatement,		getPublicKeyFromSIWEStatement,
isValidSIWEMessage,		isValidSIWEMessage,
isValidSIWEStatementWithPublicKey,		isValidSIWEStatementWithPublicKey,
primaryIdentityPublicKeyRegex,		primaryIdentityPublicKeyRegex,
} from 'lib/utils/siwe-utils.js';		} from 'lib/utils/siwe-utils.js';
import {		import {
tShape,		tShape,
tPlatformDetails,		tPlatformDetails,
tPassword,		tPassword,
tEmail,		tEmail,
tOldValidUsername,		tOldValidUsername,
tRegex,		tRegex,
		tID,
} from 'lib/utils/validation-utils.js';		} from 'lib/utils/validation-utils.js';

import {		import {
entryQueryInputValidator,		entryQueryInputValidator,
newEntryQueryInputValidator,		newEntryQueryInputValidator,
normalizeCalendarQuery,		normalizeCalendarQuery,
verifyCalendarQueryThreadIDs,		verifyCalendarQueryThreadIDs,
} from './entry-responders.js';		} from './entry-responders.js';
▲ Show 20 Lines • Show All 105 Lines • ▼ Show 20 Lines	return {
},		},
};		};
}		}

const deleteAccountRequestInputValidator = tShape({		const deleteAccountRequestInputValidator = tShape({
password: t.maybe(tPassword),		password: t.maybe(tPassword),
});		});

		export const logOutResponseValidator: TInterface<LogOutResponse> =
		tShape<LogOutResponse>({
		currentUserInfo: loggedOutUserInfoValidator,
		});

async function accountDeletionResponder(		async function accountDeletionResponder(
viewer: Viewer,		viewer: Viewer,
input: any,		input: any,
): Promise<LogOutResponse> {		): Promise<LogOutResponse> {
const request: DeleteAccountRequest = input;		const request: DeleteAccountRequest = input;
await validateInput(viewer, deleteAccountRequestInputValidator, request);		await validateInput(viewer, deleteAccountRequestInputValidator, request);
const result = await deleteAccount(viewer, request);		const result = await deleteAccount(viewer, request);
invariant(result, 'deleteAccount should return result if handed request');		invariant(result, 'deleteAccount should return result if handed request');
Show All 13 Lines	const registerRequestInputValidator = tShape({
deviceTokenUpdateRequest: t.maybe(deviceTokenUpdateRequestInputValidator),		deviceTokenUpdateRequest: t.maybe(deviceTokenUpdateRequestInputValidator),
platformDetails: tPlatformDetails,		platformDetails: tPlatformDetails,
// We include `primaryIdentityPublicKey` to avoid breaking		// We include `primaryIdentityPublicKey` to avoid breaking
// old clients, but we no longer do anything with it.		// old clients, but we no longer do anything with it.
primaryIdentityPublicKey: t.maybe(tRegex(primaryIdentityPublicKeyRegex)),		primaryIdentityPublicKey: t.maybe(tRegex(primaryIdentityPublicKeyRegex)),
signedIdentityKeysBlob: t.maybe(signedIdentityKeysBlobValidator),		signedIdentityKeysBlob: t.maybe(signedIdentityKeysBlobValidator),
});		});

		export const registerResponseValidator: TInterface<RegisterResponse> =
		tShape<RegisterResponse>({
		id: t.String,
		rawMessageInfos: t.list(rawMessageInfoValidator),
		currentUserInfo: t.union([
		oldLoggedInUserInfoValidator,
		loggedInUserInfoValidator,
		]),
		cookieChange: tShape({
		threadInfos: t.dict(t.String, rawThreadInfoValidator),
		userInfos: t.list(userInfoValidator),
		}),
		});

async function accountCreationResponder(		async function accountCreationResponder(
viewer: Viewer,		viewer: Viewer,
input: any,		input: any,
): Promise<RegisterResponse> {		): Promise<RegisterResponse> {
const request: RegisterRequest = input;		const request: RegisterRequest = input;
await validateInput(viewer, registerRequestInputValidator, request);		await validateInput(viewer, registerRequestInputValidator, request);
const { signedIdentityKeysBlob } = request;		const { signedIdentityKeysBlob } = request;
if (signedIdentityKeysBlob) {		if (signedIdentityKeysBlob) {
▲ Show 20 Lines • Show All 131 Lines • ▼ Show 20 Lines	const logInRequestInputValidator = tShape({
platformDetails: tPlatformDetails,		platformDetails: tPlatformDetails,
source: t.maybe(t.enums.of(values(logInActionSources))),		source: t.maybe(t.enums.of(values(logInActionSources))),
// We include `primaryIdentityPublicKey` to avoid breaking		// We include `primaryIdentityPublicKey` to avoid breaking
// old clients, but we no longer do anything with it.		// old clients, but we no longer do anything with it.
primaryIdentityPublicKey: t.maybe(tRegex(primaryIdentityPublicKeyRegex)),		primaryIdentityPublicKey: t.maybe(tRegex(primaryIdentityPublicKeyRegex)),
signedIdentityKeysBlob: t.maybe(signedIdentityKeysBlobValidator),		signedIdentityKeysBlob: t.maybe(signedIdentityKeysBlobValidator),
});		});

		export const logInResponseValidator: TInterface<LogInResponse> =
		tShape<LogInResponse>({
		currentUserInfo: t.union([
		loggedInUserInfoValidator,
		oldLoggedInUserInfoValidator,
		]),
		rawMessageInfos: t.list(rawMessageInfoValidator),
		truncationStatuses: messageTruncationStatusesValidator,
		userInfos: t.list(userInfoValidator),
		rawEntryInfos: t.maybe(t.list(rawEntryInfoValidator)),
		serverTime: t.Number,
		cookieChange: tShape({
		threadInfos: t.dict(tID, rawThreadInfoValidator),
		userInfos: t.list(userInfoValidator),
		}),
		notAcknowledgedPolicies: t.maybe(t.list(policyTypeValidator)),
		});

async function logInResponder(		async function logInResponder(
viewer: Viewer,		viewer: Viewer,
input: any,		input: any,
): Promise<LogInResponse> {		): Promise<LogInResponse> {
await validateInput(viewer, logInRequestInputValidator, input);		await validateInput(viewer, logInRequestInputValidator, input);
const request: LogInRequest = input;		const request: LogInRequest = input;

let identityKeys: ?IdentityKeysBlob;		let identityKeys: ?IdentityKeysBlob;
▲ Show 20 Lines • Show All 281 Lines • Show Last 20 Lines