Page MenuHomePhabricator
Differential D8340

[native] Consume `useNativeUpdateUserImageAvatar` in `useSelectFromGalleryAndUpdateUserAvatar`
ClosedPublic
Actions

Authored by atul on Jun 27 2023, 12:25 PM.
Tags
None
Referenced Files
F2165116: D8340.diff
Tue, Jul 2, 12:57 AM
Unknown Object (File)
Sat, Jun 29, 3:48 PM
Unknown Object (File)
Sat, Jun 29, 5:31 AM
Unknown Object (File)
Mon, Jun 24, 2:50 PM
Unknown Object (File)
Mon, Jun 24, 2:32 PM
Unknown Object (File)
Mon, Jun 24, 11:59 AM
Unknown Object (File)
Mon, Jun 24, 9:04 AM
Unknown Object (File)
Mon, Jun 17, 8:14 PM
View All 65 Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
rohan
Commits
rCOMM13c5d23b5537: [native] Consume `useNativeUpdateUserImageAvatar` in…
Summary

There is now only one usage of updateImageUserAvatar from *EditUserAvatarProvider and it's in useNativeUpdateUserImageAvatar where the call is wrapped in a try/catch with native-specific "error surfacing" handled in the catch block.

Depends on D8339

Test Plan

selectFromGalleryAndUpdateUserAvatar is used in one place: EditUserAvatar. Specifically the select image from gallery flow.

Similar to D8339, will break update_user_avatar endpoint and ensure that alert surfaces as expected:

8780c8.png (282×584 px, 106 KB)

Will also test "happy case" where the update_user_avatar endpoint is working as expected.

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D8340 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jun 27 2023, 12:25 PM
Herald added a subscriber: tomek. · View Herald TranscriptJun 27 2023, 12:25 PM
atul published this revision for review.Jun 27 2023, 12:25 PM
atul edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B20555: Diff 28189.Jun 27 2023, 12:43 PM
atul added a child revision: D8341: [native] Introduce `useNativeSetUserAvatar` and use throughout `native`.Jun 27 2023, 2:47 PM
ashoat accepted this revision.Jun 28 2023, 5:54 PM
This revision is now accepted and ready to land.Jun 28 2023, 5:54 PM
atul updated this revision to Diff 29195.Jul 28 2023, 12:37 PM
atul edited the test plan for this revision. (Show Details)

rebase before landing

This revision was landed with ongoing or failed builds.Jul 28 2023, 12:40 PM
Closed by commit rCOMM13c5d23b5537: [native] Consume `useNativeUpdateUserImageAvatar` in… (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM13c5d23b5537: [native] Consume `useNativeUpdateUserImageAvatar` in….
Harbormaster completed remote builds in B21316: Diff 29195.Jul 28 2023, 1:00 PM
atul mentioned this in D8741: [native] Consume `useNativeUpdateThreadImageAvatar` in `useSelectFromGalleryAndUpdateImageAvatar`.Aug 5 2023, 8:36 PM
atul mentioned this in rCOMM77ddd5a08fb9: [native] Consume `useNativeUpdateThreadImageAvatar` in….Aug 8 2023, 12:25 AM

Revision Contents
Changeset List

PathSize
native/
avatars/
8 lines

Diff 29195

View Options

native/avatars/avatar-hooks.js

Loading...