Page MenuHomePhabricator
Differential D8342

[lib][native] Remove `displayFailureAlert` prop from `*EditUserAvatarProvider`
ClosedPublic
Actions

Authored by atul on Jun 27 2023, 2:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 5, 4:43 PM
Unknown Object (File)
Tue, Dec 31, 12:17 AM
Unknown Object (File)
Tue, Dec 31, 12:17 AM
Unknown Object (File)
Tue, Dec 31, 12:17 AM
Unknown Object (File)
Tue, Dec 31, 12:16 AM
Unknown Object (File)
Tue, Dec 31, 12:09 AM
Unknown Object (File)
Mon, Dec 23, 4:18 AM
Unknown Object (File)
Mon, Dec 23, 3:31 AM
View All Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
rohan
Commits
rCOMM42871bb1c4bb: [lib][native] Remove `displayFailureAlert` prop from `*EditUserAvatarProvider`
Summary

As of D8341 we no longer use or need this prop. Surfacing of errors is handled by platform-specific code for consistency.

Now we just need to get rid of useUploadSelectedMedia and we can consolidate NativeEditUserAvatarProvider, WebEditUserAvatarProvider, and BaseEditUserAvatarProvider into a single platform-agnostic EditUserAvatarProvider.

Depends on D8341

Test Plan

NA/flow/eslint

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D8342 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jun 27 2023, 2:54 PM
Herald added a subscriber: tomek. · View Herald TranscriptJun 27 2023, 2:54 PM
atul published this revision for review.Jun 27 2023, 2:55 PM

On second thought, this totally could've been squashed with D8341

Harbormaster completed remote builds in B20560: Diff 28195.Jun 27 2023, 3:13 PM
atul added a child revision: D8343: Move registrationMode-related logic from `setUserAvatar` to `nativeSetUserAvatar`.Jun 27 2023, 5:19 PM
ashoat accepted this revision.Jun 28 2023, 5:56 PM
This revision is now accepted and ready to land.Jun 28 2023, 5:56 PM
atul updated this revision to Diff 29199.Jul 28 2023, 12:56 PM

rebase and land

This revision was landed with ongoing or failed builds.Jul 28 2023, 12:59 PM
Closed by commit rCOMM42871bb1c4bb: [lib][native] Remove `displayFailureAlert` prop from `*EditUserAvatarProvider` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM42871bb1c4bb: [lib][native] Remove `displayFailureAlert` prop from `*EditUserAvatarProvider`.
Harbormaster completed remote builds in B21318: Diff 29199.Jul 28 2023, 1:26 PM
atul mentioned this in D8758: [lib][native] Remove `displayFailureAlert` prop from `EditThreadAvatarProvider`.Aug 8 2023, 1:40 AM
atul mentioned this in rCOMM752b499b6fa2: [lib][native] Remove `displayFailureAlert` prop from `EditThreadAvatarProvider`.Aug 8 2023, 10:25 PM

Revision Contents
Changeset List

Diff 29199

View Options

lib/components/base-edit-user-avatar-provider.react.js

Loading...
View Options

native/avatars/native-edit-user-avatar-provider.react.js

Loading...