Page MenuHomePhabricator
Differential D8348

Rename `BaseEditUserAvatarProvider` to `EditUserAvatarProvider`
ClosedPublic
Actions

Authored by atul on Jun 27 2023, 6:29 PM.
Tags
None
Referenced Files
F3758617: D8348.id28201.diff
Fri, Jan 10, 8:56 AM
Unknown Object (File)
Wed, Jan 8, 4:10 PM
Unknown Object (File)
Sun, Jan 5, 11:14 PM
Unknown Object (File)
Sun, Jan 5, 4:42 PM
Unknown Object (File)
Sun, Jan 5, 12:16 AM
Unknown Object (File)
Tue, Dec 31, 12:18 AM
Unknown Object (File)
Tue, Dec 31, 12:18 AM
Unknown Object (File)
Tue, Dec 31, 12:18 AM
View All Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
rohan
Commits
rCOMM875404b0f104: Rename `BaseEditUserAvatarProvider` to `EditUserAvatarProvider`
Summary

Quick followup to D8347.

Just a simple rename + imports autofixed by IDE. Kept it as a separate diff from D8347 to make things easier to review.

Depends on D8347

Test Plan

Flow/ESLint/CI

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Jun 27 2023, 6:29 PM
Herald added a subscriber: tomek. · View Herald TranscriptJun 27 2023, 6:29 PM
atul published this revision for review.Jun 27 2023, 6:30 PM
Harbormaster completed remote builds in B20566: Diff 28201.Jun 27 2023, 6:47 PM
rohan accepted this revision.Jun 28 2023, 10:16 AM
This revision is now accepted and ready to land.Jun 28 2023, 10:16 AM
atul added a child revision: D8360: [lib] Rename `updateImageUserAvatar` to `baseUpdateImageUserAvatar` in `EditUserAvatarProvider`.Jun 28 2023, 12:40 PM
atul added a child revision: D8363: [lib] Consolidate `baseUpdateImageUserAvatar` into `baseSetUserAvatar`.Jun 28 2023, 3:10 PM
atul removed a child revision: D8363: [lib] Consolidate `baseUpdateImageUserAvatar` into `baseSetUserAvatar`.Jun 28 2023, 3:49 PM
atul updated this revision to Diff 29215.Jul 28 2023, 2:18 PM

address merge conflicts

atul updated this revision to Diff 29216.Jul 28 2023, 2:18 PM

rebase and land

This revision was landed with ongoing or failed builds.Jul 28 2023, 2:20 PM
Closed by commit rCOMM875404b0f104: Rename `BaseEditUserAvatarProvider` to `EditUserAvatarProvider` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM875404b0f104: Rename `BaseEditUserAvatarProvider` to `EditUserAvatarProvider`.
Harbormaster completed remote builds in B21328: Diff 29215.Jul 28 2023, 3:35 PM
Harbormaster completed remote builds in B21329: Diff 29216.Jul 28 2023, 3:48 PM

Revision Contents
Changeset List

Diff 29217

View Options

lib/components/base-edit-user-avatar-provider.react.js

Loading...
View Options

lib/components/edit-user-avatar-provider.react.js

Loading...
View Options

native/account/registration/avatar-selection.react.js

Loading...
View Options

native/account/registration/emoji-avatar-selection.react.js

Loading...
View Options

native/avatars/avatar-hooks.js

Loading...
View Options

native/avatars/edit-user-avatar.react.js

Loading...
View Options

native/profile/emoji-user-avatar-creation.react.js

Loading...
View Options

native/root.react.js

Loading...
View Options

web/app.react.js

Loading...
View Options

web/avatars/edit-user-avatar-menu.react.js

Loading...
View Options

web/avatars/edit-user-avatar.react.js

Loading...
View Options

web/avatars/emoji-avatar-selection-modal.react.js

Loading...