Page MenuHomePhabricator
Differential D8363

[lib] Consolidate `baseUpdateImageUserAvatar` into `baseSetUserAvatar`
ClosedPublic
Actions

Authored by atul on Jun 28 2023, 3:10 PM.
Tags
None
Referenced Files
F3520052: D8363.id29221.diff
Sun, Dec 22, 11:18 PM
F3518281: D8363.diff
Sun, Dec 22, 7:26 PM
Unknown Object (File)
Wed, Dec 11, 1:32 PM
Unknown Object (File)
Tue, Dec 10, 9:37 PM
Unknown Object (File)
Sat, Nov 23, 1:20 PM
Unknown Object (File)
Sat, Nov 23, 7:09 AM
Unknown Object (File)
Sat, Nov 23, 7:09 AM
Unknown Object (File)
Sat, Nov 23, 3:36 AM
View All Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
rohan
Commits
rCOMM3285a759aed9: [lib] Consolidate `baseUpdateImageUserAvatar` into `baseSetUserAvatar`
Summary

After removing all the platform-specific stuff from baseUpdateImageUserAvatar and baseSetUserAvatar, there was one line different between them. Seemed simpler to handle with a conditional than two separate functions. The less code the better?

Depends on D8360

Test Plan

Close reading, made sure spinner continued to behave as expected when updating image avatar on native.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Jun 28 2023, 3:10 PM
Herald added a subscriber: tomek. · View Herald TranscriptJun 28 2023, 3:10 PM
atul published this revision for review.Jun 28 2023, 3:10 PM
Harbormaster completed remote builds in B20596: Diff 28234.Jun 28 2023, 3:29 PM
atul edited the summary of this revision. (Show Details)Jun 28 2023, 3:48 PM
atul added a parent revision: D8360: [lib] Rename `updateImageUserAvatar` to `baseUpdateImageUserAvatar` in `EditUserAvatarProvider`.
atul removed a parent revision: D8348: Rename `BaseEditUserAvatarProvider` to `EditUserAvatarProvider`.
atul added a child revision: D8364: [web] Move `exifRotate` from `input-state-container` to `media-utils`.Jun 28 2023, 3:50 PM
ashoat accepted this revision.Jun 28 2023, 6:48 PM
This revision is now accepted and ready to land.Jun 28 2023, 6:48 PM
atul updated this revision to Diff 29220.Jul 28 2023, 2:45 PM

resolve merge conflicts and land

This revision was landed with ongoing or failed builds.Jul 28 2023, 2:47 PM
Closed by commit rCOMM3285a759aed9: [lib] Consolidate `baseUpdateImageUserAvatar` into `baseSetUserAvatar` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM3285a759aed9: [lib] Consolidate `baseUpdateImageUserAvatar` into `baseSetUserAvatar`.
Harbormaster completed remote builds in B21331: Diff 29220.Jul 28 2023, 4:13 PM
atul mentioned this in D8774: [lib] Consolidate `updateImageThreadAvatar` into `baseSetThreadAvatar`.Aug 9 2023, 3:21 PM
atul mentioned this in rCOMM4624708581d2: [lib] Consolidate `updateImageThreadAvatar` into `baseSetThreadAvatar`.Aug 9 2023, 10:27 PM

Revision Contents
Changeset List

PathSize
lib/
components/
31 lines
native/
avatars/
6 lines

Diff 29221

View Options

lib/components/edit-user-avatar-provider.react.js

Loading...
View Options

native/avatars/avatar-hooks.js

Loading...