Page MenuHomePhabricator

Move `native`-specific `uploadSelectedMedia` from `updateImageThreadAvatar` to `nativeUpdateImageThreadAvatar`
ClosedPublic

Authored by atul on Aug 9 2023, 12:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 13, 12:08 PM
Unknown Object (File)
Fri, Jan 10, 7:20 PM
Unknown Object (File)
Fri, Jan 10, 7:18 PM
Unknown Object (File)
Fri, Jan 10, 6:19 PM
Unknown Object (File)
Fri, Jan 10, 4:20 PM
Unknown Object (File)
Fri, Jan 10, 4:18 PM
Unknown Object (File)
Fri, Jan 10, 3:20 PM
Unknown Object (File)
Fri, Jan 10, 2:49 PM
Subscribers

Details

Summary

We remove the native-specific uploadSelectedMedia call from updateImageThreadAvatar and move it to the native-specific nativeUpdateThreadImageAvatar.

As of this diff, updateImageThreadAvatar now takes (imageAvatarUpdateRequest: ImageAvatarDBContent) rather than the native-specific (selection: NativeMediaSelection).

This diff also eliminates all usages of useUploadSelectedMedia, which means we can remvoe the prop in a subsequent diff at which point EditThreadAvatarProvider will be platform-agnostic.

Test Plan

Continue to be able to set image thread avatars on native as expected.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage