[keyserver] Group entry and message infos by threadID instead of iterating over them for each JOIN_THREAD update
ClosedPublic
Actions

Authored by tomek on Aug 10 2023, 5:03 AM.

Details

Reviewers

kamil
bartek
inka
ashoat

Commits

rCOMM5cbf9f2c0fef: [keyserver] Group entry and message infos by threadID instead of iterating over…

Summary

For each JOIN_THREAD update we were iterating over all the entry / message infos. Grouping them by threadID will improve the performance when we deliver more than one action of this type.

https://linear.app/comm/issue/ENG-4593/improve-updateinfosfromrawupdateinfos-performance-by-using-a-map

Depends on D8768

Test Plan

Reintroduce removed code and add console logs where we compare previous with new results. Then join a thread and check if the result is the same.

Diff Detail

Repository

rCOMM Comm

Branch

state-sync

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Aug 10 2023, 5:03 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 10 2023, 5:03 AM

Harbormaster completed remote builds in B21687: Diff 29807.Aug 10 2023, 5:22 AM

tomek requested review of this revision.Aug 10 2023, 5:22 AM

ashoat accepted this revision.Aug 10 2023, 10:07 AM

This revision is now accepted and ready to land.Aug 10 2023, 10:07 AM

Closed by commit rCOMM5cbf9f2c0fef: [keyserver] Group entry and message infos by threadID instead of iterating over… (authored by tomek). · Explain WhyAug 22 2023, 5:51 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM5cbf9f2c0fef: [keyserver] Group entry and message infos by threadID instead of iterating over….

Revision Contents
Changeset List

Path

Size

keyserver/

src/

creators/

update-creator.js

35 lines

Diff 29807

View Options

keyserver/src/creators/update-creator.js

[keyserver] Group entry and message infos by threadID instead of iterating over them for each JOIN_THREAD updateClosedPublicActions