Paths

Table of Contentst

-
services/identity/src/
-
identity/
-
src/
1/1
client_service.rs
1/1
grpc_utils.rs

[identity] getInboundKeysForUser RPC implementation
ClosedPublic
Actions

Authored by varun on Aug 17 2023, 9:48 PM.

Details

Reviewers

• jon
bartek

Commits

rCOMMa4954c15ddff: [identity] getInboundKeysForUser RPC implementation

Summary

use previously implemented helpers to implement the actual RPC method

Note that this intentionally does not include one-time keys (not required for inbound, only outbound).

Depends on D8765

Test Plan

called the RPC for an existing user in my local DDB table and got back required keys.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Aug 17 2023, 9:48 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 17 2023, 9:48 PM

Harbormaster completed remote builds in B21882: Diff 30060.Aug 17 2023, 10:08 PM

varun requested review of this revision.Aug 17 2023, 10:08 PM

• jon requested changes to this revision.Aug 18 2023, 12:58 PM

• jon added inline comments.

services/identity/src/client_service.rs
826–834	We should probably do something like `.filter_map (\|r\| r.map_err(\|e\| error!("{}", e)).ok()).collect()` to just collect the valid results. As written, I think if any of the `InboundKeyInfo::try_from` calls fail, it will make the entire query fail. https://doc.rust-lang.org/rust-by-example/error/iter_result.html#fail-the-entire-operation-with-collect

This revision now requires changes to proceed.Aug 18 2023, 12:58 PM

address feedback

move InboundKeyInfo import

Harbormaster completed remote builds in B21961: Diff 30158.Aug 21 2023, 11:01 AM

Harbormaster completed remote builds in B21962: Diff 30159.

bartek accepted this revision.Aug 22 2023, 12:26 AM

• jon accepted this revision.Aug 23 2023, 9:03 AM

• jon added inline comments.

services/identity/src/client_service.rs
828–836 ↗	(On Diff #30159)	I think we want `filter_map` to remove all the `Err`'s, and so we would only get back a HashMap. Would need to do some testing to verify though. If this doesn't yield results, I would just continue as-is.

This revision is now accepted and ready to land.Aug 23 2023, 9:03 AM

varun added inline comments.Aug 30 2023, 11:38 AM

services/identity/src/client_service.rs
828–836 ↗	(On Diff #30159)	kept the match statement but addressed your overall point about filtering out the `Err`s

Closed by commit rCOMMa4954c15ddff: [identity] getInboundKeysForUser RPC implementation (authored by varun). · Explain WhyAug 30 2023, 11:38 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMa4954c15ddff: [identity] getInboundKeysForUser RPC implementation.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

client_service.rs

71 lines

grpc_utils.rs

8 lines

Diff 30060

View Options

services/identity/src/client_service.rs

	Show All 27 Lines
	import {			import {
	type ServerServerRequest,			type ServerServerRequest,
	serverServerRequestValidator,			serverServerRequestValidator,
	type ClientServerRequest,			type ClientServerRequest,
	type ClientResponse,			type ClientResponse,
	type ClientClientResponse,			type ClientClientResponse,
	} from './request-types.js';			} from './request-types.js';
	import type { SessionState, SessionIdentification } from './session-types.js';			import type { SessionState, SessionIdentification } from './session-types.js';
	import { type RawThreadInfos } from './thread-types.js';			import type {
				RawThreadInfos,
				MinimallyEncodedRawThreadInfos,
				} from './thread-types.js';
	import {			import {
	type ClientUpdatesResult,			type ClientUpdatesResult,
	type ClientUpdatesResultWithUserInfos,			type ClientUpdatesResultWithUserInfos,
	type ServerUpdatesResult,			type ServerUpdatesResult,
	serverUpdatesResultValidator,			serverUpdatesResultValidator,
	type ServerUpdatesResultWithUserInfos,			type ServerUpdatesResultWithUserInfos,
	serverUpdatesResultWithUserInfosValidator,			serverUpdatesResultWithUserInfosValidator,
	} from './update-types.js';			} from './update-types.js';
	▲ Show 20 Lines • Show All 134 Lines • ▼ Show 20 Lines
	export const stateSyncPayloadTypes = Object.freeze({			export const stateSyncPayloadTypes = Object.freeze({
	FULL: 0,			FULL: 0,
	INCREMENTAL: 1,			INCREMENTAL: 1,
	});			});

	export const fullStateSyncActionType = 'FULL_STATE_SYNC';			export const fullStateSyncActionType = 'FULL_STATE_SYNC';
	export type BaseFullStateSync = {			export type BaseFullStateSync = {
	+messagesResult: MessagesResponse,			+messagesResult: MessagesResponse,
	+threadInfos: RawThreadInfos,
	+rawEntryInfos: $ReadOnlyArray<RawEntryInfo>,			+rawEntryInfos: $ReadOnlyArray<RawEntryInfo>,
	+userInfos: $ReadOnlyArray<UserInfo>,			+userInfos: $ReadOnlyArray<UserInfo>,
	+updatesCurrentAsOf: number,			+updatesCurrentAsOf: number,
	};			};
	const baseFullStateSyncValidator = tShape<BaseFullStateSync>({			const baseFullStateSyncValidator = tShape<BaseFullStateSync>({
	messagesResult: messagesResponseValidator,			messagesResult: messagesResponseValidator,
	threadInfos: t.dict(tID, rawThreadInfoValidator),
	rawEntryInfos: t.list(rawEntryInfoValidator),			rawEntryInfos: t.list(rawEntryInfoValidator),
	userInfos: t.list(userInfoValidator),			userInfos: t.list(userInfoValidator),
	updatesCurrentAsOf: t.Number,			updatesCurrentAsOf: t.Number,
	});			});

	export type ClientFullStateSync = {			export type ClientFullStateSync = $ReadOnly<{
	...BaseFullStateSync,			...BaseFullStateSync,
				+threadInfos: MinimallyEncodedRawThreadInfos,
	+currentUserInfo: CurrentUserInfo,			+currentUserInfo: CurrentUserInfo,
	};			}>;
	export type StateSyncFullActionPayload = {			export type StateSyncFullActionPayload = $ReadOnly<{
	...ClientFullStateSync,			...ClientFullStateSync,
	+calendarQuery: CalendarQuery,			+calendarQuery: CalendarQuery,
	+keyserverID: string,			+keyserverID: string,
	};			}>;
	export type ClientStateSyncFullSocketPayload = {			export type ClientStateSyncFullSocketPayload = $ReadOnly<{
	...ClientFullStateSync,			...ClientFullStateSync,
	+type: 0,			+type: 0,
	// Included iff client is using sessionIdentifierTypes.BODY_SESSION_ID			// Included iff client is using sessionIdentifierTypes.BODY_SESSION_ID
	+sessionID?: string,			+sessionID?: string,
	};			}>;

	export type ServerFullStateSync = {			export type ServerFullStateSync = $ReadOnly<{
	...BaseFullStateSync,			...BaseFullStateSync,
				+threadInfos: RawThreadInfos,
	+currentUserInfo: CurrentUserInfo,			+currentUserInfo: CurrentUserInfo,
	};			}>;
	const serverFullStateSyncValidator = tShape<ServerFullStateSync>({			const serverFullStateSyncValidator = tShape<ServerFullStateSync>({
	...baseFullStateSyncValidator.meta.props,			...baseFullStateSyncValidator.meta.props,
				threadInfos: t.dict(tID, rawThreadInfoValidator),
	currentUserInfo: currentUserInfoValidator,			currentUserInfo: currentUserInfoValidator,
	});			});

	export type ServerStateSyncFullSocketPayload = {			export type ServerStateSyncFullSocketPayload = {
				atulAuthorUnsubmitted Done Inline Actions Get the following when I try making this `$ReadOnly`: atul: Get the following when I try making this `$ReadOnly`: {F1058362}
	...ServerFullStateSync,			...ServerFullStateSync,
	+type: 0,			+type: 0,
	// Included iff client is using sessionIdentifierTypes.BODY_SESSION_ID			// Included iff client is using sessionIdentifierTypes.BODY_SESSION_ID
	+sessionID?: string,			+sessionID?: string,
	};			};
	const serverStateSyncFullSocketPayloadValidator =			const serverStateSyncFullSocketPayloadValidator =
	tShape<ServerStateSyncFullSocketPayload>({			tShape<ServerStateSyncFullSocketPayload>({
	...serverFullStateSyncValidator.meta.props,			...serverFullStateSyncValidator.meta.props,
	▲ Show 20 Lines • Show All 328 Lines • Show Last 20 Lines