Page MenuHomePhabricator

[lib][native][web] Use connection from keyserverStore
ClosedPublic

Authored by inka on Aug 23 2023, 8:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 24, 6:51 AM
Unknown Object (File)
Fri, Apr 18, 5:03 AM
Unknown Object (File)
Wed, Apr 9, 12:23 AM
Unknown Object (File)
Thu, Apr 3, 2:20 PM
Unknown Object (File)
Thu, Apr 3, 8:49 AM
Unknown Object (File)
Wed, Apr 2, 8:45 PM
Unknown Object (File)
Wed, Apr 2, 2:12 AM
Unknown Object (File)
Mar 1 2025, 3:25 PM
Subscribers

Details

Summary

issue: https://linear.app/comm/issue/ENG-4460/refactor-connection-field
The second step is to start using connection from keyserverStore.

Some explanations:
master-reducer: once actions have a defined way of extracting keyserver id from their arguments we will use the correct id instead of ashoatKeyserverID
about invariants:

Test Plan

ran yarn flow-all. Checked that the app works, and the "Disconnected" bar is not present when app is connected, and is present when keyserver is down.

Diff Detail

Repository
rCOMM Comm
Branch
inka/redux3
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka requested review of this revision.Aug 23 2023, 9:02 AM

Thank you for all links for the invariants!

This revision is now accepted and ready to land.Aug 23 2023, 10:45 PM