Differential D8920

Revert "[native] fix RetrySend not visible when message fails"
ClosedPublic
Actions

Authored by ginsu on Aug 22 2023, 12:14 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 8, 8:24 AM

	Unknown Object (File)
	Tue, Apr 8, 4:58 AM

	Unknown Object (File)
	Tue, Apr 8, 3:40 AM

	Unknown Object (File)
	Sun, Apr 6, 9:33 PM

	Unknown Object (File)
	Tue, Apr 1, 8:34 AM

	Unknown Object (File)
	Mon, Mar 31, 10:40 PM

	Unknown Object (File)
	Mar 11 2025, 3:56 PM

	Unknown Object (File)
	Mar 3 2025, 1:35 PM

View All 88 Files

Subscribers

Details

Reviewers

ashoat
tomek
atul

Commits

rCOMM7dde47e88e9e: Revert "[native] fix RetrySend not visible when message fails"

Summary

This reverts commit df101e5f740acb88690353c7412a2e5bc9c5413a.

Test Plan

n/a

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Aug 22 2023, 12:14 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 22 2023, 12:15 PM

ginsu added reviewers: ashoat, tomek, atul.Aug 22 2023, 12:16 PM

ginsu added a child revision: D8921: [native] fix broken messaging experience from forcing incorrect message height measurements.Aug 22 2023, 12:21 PM

Harbormaster completed remote builds in B22031: Diff 30245.Aug 22 2023, 12:34 PM

ginsu requested review of this revision.Aug 22 2023, 12:34 PM

ashoat accepted this revision.Aug 22 2023, 9:14 PM

This revision is now accepted and ready to land.Aug 22 2023, 9:14 PM

Closed by commit rCOMM7dde47e88e9e: Revert "[native] fix RetrySend not visible when message fails" (authored by ginsu). · Explain WhyAug 23 2023, 9:10 AM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM7dde47e88e9e: Revert "[native] fix RetrySend not visible when message fails".

Revision Contents
Changeset List

Path

Size

native/

chat/

composed-message.react.js

16 lines

failed-send.react.js

1 line

message.react.js

22 lines

robotext-message.react.js

9 lines

Diff 30267

native/chat/composed-message.react.js

This file was moved to lib/types/websocket/heartbeat-types.js.

native/chat/failed-send.react.js

This file was moved to lib/types/websocket/heartbeat-types.js.

native/chat/message.react.js

This file was moved to lib/types/websocket/heartbeat-types.js.

native/chat/robotext-message.react.js

This file was moved to lib/types/websocket/heartbeat-types.js.