[lib] Add reports service facts
ClosedPublic
Actions

Authored by bartek on Aug 30 2023, 11:41 PM.

Details

Reviewers

kamil
michal
tomek
inka

Commits

rCOMMcc25100ea231: [lib] Add reports service facts

Summary

Similiar to other services, add facts file with endpoint info for reports service.
We expose only single endpoint meaningful to clients. Other endpoints are staff only so I haven't added them.

Test Plan

flow

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Aug 30 2023, 11:41 PM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptAug 30 2023, 11:41 PM

bartek added a child revision: D9042: [lib] Add function to send reports.Aug 30 2023, 11:44 PM

Make types readonly

Harbormaster completed remote builds in B22289: Diff 30615.Aug 31 2023, 12:00 AM

bartek published this revision for review.Aug 31 2023, 12:07 AM

bartek added inline comments.

lib/facts/reports-service.js
5–8	I wish flow had TypeScript's `as const` - playground link

Harbormaster completed remote builds in B22296: Diff 30621.Aug 31 2023, 12:14 AM

Should we also update the docs with the new facts file?

This revision is now accepted and ready to land.Aug 31 2023, 5:07 AM

In D9041#266461, @tomek wrote:

Should we also update the docs with the new facts file?

Which docs? Other services' facts don't have any docs IIRC 🤔

In D9041#266850, @bartek wrote:

In D9041#266461, @tomek wrote:

Should we also update the docs with the new facts file?

Which docs? Other services' facts don't have any docs IIRC 🤔

If the app works correctly after fresh checkout without these facts, then we're fine. But if this file is required for the app to work, then we should mention it somewhere (I remember that we're mentioning web and landing facts somewhere).