Paths

Table of Contentst

Differential D8959

[blob-service] Remove gRPC service, change default port
ClosedPublic
Actions

Authored by bartek on Aug 26 2023, 12:16 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 13, 7:22 PM

	Unknown Object (File)
	Wed, Nov 13, 7:17 PM

	Unknown Object (File)
	Sun, Nov 10, 5:54 PM

	Unknown Object (File)
	Sun, Oct 27, 5:01 PM

	Unknown Object (File)
	Oct 12 2024, 11:51 AM

	Unknown Object (File)
	Oct 2 2024, 8:14 PM

	Unknown Object (File)
	Sep 27 2024, 11:57 PM

	Unknown Object (File)
	Sep 27 2024, 11:57 PM

View All 78 Files

Subscribers

Details

Reviewers

michal
varun
• patryk
• jon

Commits

rCOMM8c7226c8debb: [blob-service] Remove gRPC service, change default port

Summary

In D8796 we removed last blob gRPC client. This diff removes gRPC server as well.

First part of ENG-4297.

Deletes all gRPC related code from Blob service.
Changes default HTTP port to 50053.

Test Plan

HTTP service still works.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Aug 26 2023, 12:16 AM

bartek held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptAug 26 2023, 12:16 AM

Herald added subscribers: tomek, ashoat. · View Herald Transcript

bartek added a child revision: D8960: [terraform][blob] Remove gRPC service.Aug 26 2023, 12:20 AM

bartek added a child revision: D8961: [blob-service] Minor AWS cleanups.Aug 26 2023, 12:23 AM

Harbormaster failed remote builds in B22113: Diff 30347!Aug 26 2023, 12:24 AM

Remove proto from dockerfile

bartek published this revision for review.Aug 26 2023, 12:43 AM

bartek added inline comments.

services/blob/src/config.rs
31 ↗	(On Diff #30350)	In response to @jon's comment in https://phab.comm.dev/D8865?id=30062#inline-56777 I decided to return this from the function so we can take advantage of both: convenience of using static `CONFIG` where it's cumbersome to pass it through args correctness from aforementioned comment - we return the config from this function so it can be just passed further wherever needed

Harbormaster completed remote builds in B22116: Diff 30350.Aug 26 2023, 12:46 AM

michal accepted this revision.Aug 28 2023, 12:44 AM

This revision is now accepted and ready to land.Aug 28 2023, 12:44 AM

michal added inline comments.Aug 28 2023, 4:44 AM

services/blob/src/config.rs
14 ↗	(On Diff #30350)	Would it make sense to remove the constant and default to the ports in `.env` like tests? One less thing to keep in sync

Closed by commit rCOMM8c7226c8debb: [blob-service] Remove gRPC service, change default port (authored by bartek). · Explain WhyAug 31 2023, 5:26 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM8c7226c8debb: [blob-service] Remove gRPC service, change default port.

Revision Contents
Changeset List

Path

Size

services/

blob/

1 line

src/

19 lines

34 lines

database/

1 line

13 lines

docker-compose.yml

2 lines

shared/

protos/

Diff 30643

services/blob/Dockerfile

Loading...

services/blob/build.rs

Loading...

services/blob/src/config.rs

Loading...

services/blob/src/constants.rs

Loading...

services/blob/src/database/mod.rs

Loading...

services/blob/src/database/old.rs

Loading...

services/blob/src/grpc.rs

Loading...

services/blob/src/main.rs

Loading...

services/docker-compose.yml

Loading...

shared/protos/blob.proto

Loading...