issue: https://linear.app/comm/issue/ENG-4794/start-persisting-the-keyserverstore
We want to persist the keyserverStore on web, apart from connection and updatesCurrentAsOf fields. updatesCurrentAsOf doesn't have a straightforward defult value - the keyserver returns
the current time or 0 depending on whether the user has accepted the policies. That's why we are using value passed from the keyserver, stored in preloadedState.
Details
Details
- Reviewers
michal kamil - Commits
- rCOMM9f39ad91f27c: [web] Start persisting keyserverStore
Checked that keyserverStore is persisted - logged the action.payload of rehydrateActionType in redux-setpu.js. Checked that the connceciotn and updatesCurrentAsOf are set to the
values defined in out function of the Transform object. Chekced that is the user has to accept the policies, the value set to updatesCurrentAsOf is 0, and the current time otherwise.
Checked that the application gets populated with data when the user accpest the policies (it doen't happen if the value of updatesCurrentAsOf is set to the current time right away).
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
LGTM
| web/redux/persist.js | ||
|---|---|---|
| 105 ↗ | (On Diff #30696) | Are we meant to stop persisting lastCommunicatedPlatformDetails in this diff? |
Comment Actions
LGTM, requesting changes to address https://phab.comm.dev/D9062#inline-57824
| web/redux/persist.js | ||
|---|---|---|
| 21–22 ↗ | (On Diff #30696) | can be merged |
| web/redux/persist.js | ||
|---|---|---|
| 142–145 ↗ | (On Diff #30696) | Actually I don't think we want to persist the sessionID. Each time we reload a web page we want a new sessionID, so persisting it doesn't make sense |