new responder that checks viewer's username and provides a signed message
attesting that the user owns that particular username. this message can then be
presented to the identity service to allow registration of a reserved username.
Details
Details
- Reviewers
atul ashoat - Commits
- rCOMM573418ac654a: [keyserver] accountOwnershipResponder
called the responder from web and verified that the signature returned with my local keyserver's ed25519 public content key
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- reserve-usernames (branched from master)
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Nice!! Some nonstandard stuff in this diff; requesting changes in the hopes that we can use the more standard mechanisms
| lib/actions/user-actions.js | ||
|---|---|---|
| 66 ↗ | (On Diff #30973) | I noticed you're missing action types here. If that's because you're not planning on using the standard dispatchActionPromise mechanism, I'd like to have some more context on that decision |
| 73 ↗ | (On Diff #30973) | Instead of this Promise.race, you can specify a custom timeout by passing a third parameter to callServerEndpoint like this |
| 82 ↗ | (On Diff #30973) | Why are you swallowing the error? I can't tell where you're going to use this, but the typical pattern is to pass the Promise to dispatchActionPromise, which will gracefully handle a promise rejection (exception) by dispatching a failed action |