Page MenuHomePhabricator

[native] Use expo-file-system uploads
ClosedPublic

Authored by patryk on Sep 12 2023, 1:43 PM.
Tags
None
Referenced Files
F3348354: D9152.id30986.diff
Fri, Nov 22, 2:34 PM
Unknown Object (File)
Thu, Oct 31, 1:14 PM
Unknown Object (File)
Thu, Oct 31, 1:14 PM
Unknown Object (File)
Thu, Oct 31, 1:14 PM
Unknown Object (File)
Thu, Oct 31, 1:14 PM
Unknown Object (File)
Sep 26 2024, 12:55 PM
Unknown Object (File)
Sep 26 2024, 12:55 PM
Unknown Object (File)
Sep 26 2024, 12:54 PM
Subscribers

Details

Summary

This diff replaces react-native-background-upload to expo-file-system upload utilities.

Depends on D9151.

Test Plan
  1. Check if uploads work properly for unencrypted images:

1a. Check if image is uploaded when app is moved to background
1b. Check if image upload is canceled when abortHandler is executed

  1. Check above steps for encrypted images.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

patryk held this revision as a draft.

code looks good, question regarding testing:

  • Have you tested it on both iOS and Android?

This code works properly on iOS, but I need to check if it is working properly on Android.

I've tested this diff on Android and it's working properly.

This revision is now accepted and ready to land.Sep 24 2023, 1:42 AM
This revision was automatically updated to reflect the committed changes.