[native] memoize BottomSheetHandle
ClosedPublic
Actions

Authored by ginsu on Sep 12 2023, 8:56 AM.

Details

Reviewers

atul
inka

Commits

rCOMMe1b680de0bbe: [native] memoize BottomSheetHandle

Summary

In D8958 I should have memoized the bottom sheet handle component. This diff addresses that concern

Test Plan

confirmed that the handle still worked as expected

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Sep 12 2023, 8:56 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 12 2023, 8:56 AM

ginsu added reviewers: atul, inka.Sep 12 2023, 8:59 AM

Harbormaster completed remote builds in B22533: Diff 30971.Sep 12 2023, 9:13 AM

ginsu requested review of this revision.Sep 12 2023, 9:13 AM

Personal preference is memoization "inside" the component w/ useMemo hook so everything is self-contained and memoization is consistent and whatnot, but this is valid

This revision is now accepted and ready to land.Sep 12 2023, 1:34 PM

address @atul's feedback

spelling :/

This revision was landed with ongoing or failed builds.Sep 12 2023, 2:05 PM

Closed by commit rCOMMe1b680de0bbe: [native] memoize BottomSheetHandle (authored by ginsu). · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMe1b680de0bbe: [native] memoize BottomSheetHandle.

Harbormaster completed remote builds in B22552: Diff 30998.Sep 12 2023, 2:27 PM

Harbormaster completed remote builds in B22553: Diff 30999.

Revision Contents
Changeset List

Path

Size

native/

bottom-sheets/

bottom-sheet-handle.react.js

19 lines

Diff 30999

View Options

native/bottom-sheets/bottom-sheet-handle.react.js

[native] memoize BottomSheetHandleClosedPublicActions