[keyserver] Print out a QR code to the terminal
ClosedPublic
Actions

Authored by rohan on Sep 13 2023, 8:59 AM.

Details

Reviewers

atul
ginsu
varun
• patryk

Commits

rCOMM5842359feb58: [keyserver] Print out a QR code to the terminal

Summary

This diff handles printing out a QR code to the terminal - the idea is that this will ultimately be displayed on the keyserver. For now I've used temporary keys, the next two diffs will encode an ephemeral AES-256 key and the ed25519 key.

Addresses ENG-4776 and ENG-4773.

Depends on D9089

Test Plan

Confirmed that toggling the flag ensures that the QR code prints out to the terminal

Screenshot 2023-09-13 at 11.54.27 AM.png (1×2 px, 1 MB)

Diff Detail

Repository

rCOMM Comm

Branch

terminal_qr

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

rohan created this revision.Sep 13 2023, 8:59 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 13 2023, 8:59 AM

rohan edited the test plan for this revision. (Show Details)Sep 13 2023, 9:00 AM

rohan edited the summary of this revision. (Show Details)

rohan added a child revision: D9181: [keyserver] Generate an AES256 key (ephemeral) to encode.Sep 13 2023, 9:04 AM

rohan added inline comments.Sep 13 2023, 9:05 AM

keyserver/src/keyserver.js
86–87	These are temporary. The AES256Key is set in the next diff, D9181 The ed25519 key will be in the diff after that

Harbormaster completed remote builds in B22592: Diff 31061.Sep 13 2023, 9:17 AM

rohan requested review of this revision.Sep 13 2023, 9:17 AM

Don't have a ton of experience with qr codes, but seems reasonable

ginsu accepted this revision.Sep 13 2023, 9:52 AM

This revision is now accepted and ready to land.Sep 13 2023, 9:52 AM

rohan added a child revision: D9202: [keyserver/web/native] Covert AES-256 key from Uint8Array representation to hex string representation.Sep 14 2023, 7:58 AM

rohan removed a child revision: D9202: [keyserver/web/native] Covert AES-256 key from Uint8Array representation to hex string representation.Sep 14 2023, 8:03 AM

Closed by commit rCOMM5842359feb58: [keyserver] Print out a QR code to the terminal (authored by rohan). · Explain WhySep 21 2023, 10:21 AM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMM5842359feb58: [keyserver] Print out a QR code to the terminal.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

keyserver.js

17 lines

Diff 31061

View Options

keyserver/src/keyserver.js

[keyserver] Print out a QR code to the terminalClosedPublicActions