[web] introduce useStaffCanSee hook for web
ClosedPublic
Actions

Authored by ginsu on Sep 13 2023, 1:49 PM.

Details

Reviewers

atul
rohan
inka

Commits

rCOMM00b30f802217: [web] introduce useStaffCanSee hook for web

Summary

I want to introduce this hook to web so that we can gate some a new appearance settings for non staff members while the light mode/color families for web project is in progress

Depends on D9193

Test Plan

flow and confirmed that the correct value was being returned by hook (returns true during dev mode or when the user is a member of the staff array)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Sep 13 2023, 1:49 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 13 2023, 1:49 PM

ginsu edited the summary of this revision. (Show Details)Sep 13 2023, 1:51 PM

ginsu added reviewers: atul, rohan, inka.

ginsu added a parent revision: D9193: [lib/native] lift useIsCurrentUserStaff hook into lib.

ginsu added a child revision: D9195: [web] introduce preferences settings in account settings.Sep 13 2023, 2:04 PM

Harbormaster completed remote builds in B22617: Diff 31096.Sep 13 2023, 2:08 PM

ginsu requested review of this revision.Sep 13 2023, 2:08 PM

Seems reasonable, does it make sense to preemptively just put this in lib as well though like useIsCurrentUserStaff

This revision is now accepted and ready to land.Sep 14 2023, 7:40 AM

Seems reasonable, does it make sense to preemptively just put this in lib as well though like useIsCurrentUserStaff

I thought about that but native has it's own version of the useStaffCanSee hook that is slightly different. The native version of useStaffCanSee also considers if the user is using a staff release as well that web does not need to consider. I thought it would make more sense/be less confusing for other devs that use this in the future if the different versions of each hook lived in their own respective platform folders, but if others disagree happy to make the necessary changes

In D9194#270776, @ginsu wrote:

Seems reasonable, does it make sense to preemptively just put this in lib as well though like useIsCurrentUserStaff

I thought about that but native has it's own version of the useStaffCanSee hook that is slightly different. The native version of useStaffCanSee also considers if the user is using a staff release as well that web does not need to consider. I thought it would make more sense/be less confusing for other devs that use this in the future if the different versions of each hook lived in their own respective platform folders, but if others disagree happy to make the necessary changes

Ah ok yeah that makes sense to me

Closed by commit rCOMM00b30f802217: [web] introduce useStaffCanSee hook for web (authored by ginsu). · Explain WhySep 14 2023, 8:29 AM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM00b30f802217: [web] introduce useStaffCanSee hook for web.