Page MenuHomePhabricator

[web] introduce AppearanceChangeModal
ClosedPublic

Authored by ginsu on Sep 14 2023, 9:05 AM.
Tags
None
Referenced Files
F3140685: D9203.id31237.diff
Sun, Nov 3, 5:07 AM
Unknown Object (File)
Thu, Oct 31, 1:50 PM
Unknown Object (File)
Thu, Oct 31, 1:50 PM
Unknown Object (File)
Thu, Oct 31, 1:50 PM
Unknown Object (File)
Thu, Oct 31, 1:50 PM
Unknown Object (File)
Thu, Oct 31, 1:50 PM
Unknown Object (File)
Thu, Oct 31, 1:46 PM
Unknown Object (File)
Sun, Oct 27, 10:24 PM

Details

Summary

This diff introduces the AppearanceChangeModal component which will be used to toggle between light and dark mode for web.

Again I want to reiterate that the designs/UI here is not finalized. @ted still needs to do an official design pass for this, but since we are only showing this internally at the moment, I prioritized getting something "quick and dirty" out so @ted and I can start testing asap with the intention that we will polish this up down the line

Test Plan

Please see screenshot below

Screenshot 2023-09-14 at 12.05.28 PM.png (2×3 px, 819 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka, rohan.
ginsu added a subscriber: ted.
web/settings/appearance-change-modal.react.js
14

This is temporary and will be replaced when I introduce the global theme redux states

ginsu requested review of this revision.Sep 14 2023, 9:23 AM
atul requested changes to this revision.Sep 17 2023, 3:04 PM
atul added inline comments.
web/settings/appearance-change-modal.react.js
38

useCallback

44

useCallback

This revision now requires changes to proceed.Sep 17 2023, 3:04 PM
ginsu edited the summary of this revision. (Show Details)

address @atul's feedback

web/settings/appearance-change-modal.react.js
14 ↗(On Diff #31237)

This is temporary and will be replaced when I introduce the global theme redux states

16–24 ↗(On Diff #31237)

I'm aware that this is not a very elegant solution here. Again want to reiterate that this is supposed to be "quick + dirty" and I anticipate that this is going to be updated after this experience goes through a design pass

This revision is now accepted and ready to land.Sep 20 2023, 1:50 PM
This revision was automatically updated to reflect the committed changes.