Page MenuHomePhabricator
Differential D9275

[services-lib] Let blob client use services token
ClosedPublic
Actions

Authored by bartek on Sep 25 2023, 5:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 7, 10:44 PM
Unknown Object (File)
Fri, Mar 7, 10:43 PM
Unknown Object (File)
Feb 21 2025, 1:36 AM
Unknown Object (File)
Jan 31 2025, 12:10 PM
Unknown Object (File)
Jan 31 2025, 12:10 PM
Unknown Object (File)
Jan 31 2025, 12:10 PM
Unknown Object (File)
Jan 29 2025, 12:20 AM
Unknown Object (File)
Jan 11 2025, 8:08 PM
View All 95 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
varun
• jon
Commits
rCOMM6a1036d0b610: [services-lib] Let blob client use services token
Summary

Changed blob client logic to use the new AuthorizationCredential enum instead of the more specific UserIdentity

Depends on D9243

Test Plan

Blob client works as before

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Sep 25 2023, 5:36 AM
bartek held this revision as a draft.
Herald added a reviewer: • jon. · View Herald TranscriptSep 25 2023, 5:36 AM
Herald added subscribers: tomek, ashoat. · View Herald Transcript
bartek added a child revision: D9276: [terraform] Add services token secret.Sep 25 2023, 5:38 AM
Harbormaster completed remote builds in B22814: Diff 31384.Sep 25 2023, 5:54 AM
bartek published this revision for review.Sep 25 2023, 5:56 AM
bartek added inline comments.
services/comm-services-lib/src/blob/client.rs
101–108

Maybe we should deprecate this function

michal accepted this revision.Sep 25 2023, 6:21 AM
michal added inline comments.
services/comm-services-lib/src/blob/client.rs
101–108

I don't have strong feelings about this, makes sense

This revision is now accepted and ready to land.Sep 25 2023, 6:21 AM
Closed by commit rCOMM6a1036d0b610: [services-lib] Let blob client use services token (authored by bartek). · Explain WhyOct 2 2023, 6:27 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM6a1036d0b610: [services-lib] Let blob client use services token.

Revision Contents
Changeset List

PathSize
services/
comm-services-lib/
src/
17 lines
blob/
30 lines

Diff 31384

View Options

services/comm-services-lib/src/auth.rs

fn main() { use futures_core::Stream;
println!("Hello, world!"); use std::pin::Pin;
use tonic::{transport::Server, Request, Response, Status};
use identity::identity_service_server::{IdentityService, IdentityServiceServer};
use identity::{
GetUserTokenRequest, GetUserTokenResponse, LoginRequest, LoginResponse, RegistrationRequest,
RegistrationResponse,
};
pub mod identity {
tonic::include_proto!("identity");
}
#[derive(Debug, Default)]
pub struct MyIdentityService {}
#[tonic::async_trait]
impl IdentityService for MyIdentityService {
type RegisterUserStream =
Pin<Box<dyn Stream<Item = Result<RegistrationResponse, Status>> + Send + 'static>>;
async fn register_user(
&self,
request: Request<tonic::Streaming<RegistrationRequest>>,
) -> Result<Response<Self::RegisterUserStream>, Status> {
println!("Got a registration request: {:?}", request);
unimplemented!()
}
type LoginUserStream =
Pin<Box<dyn Stream<Item = Result<LoginResponse, Status>> + Send + 'static>>;
async fn login_user(
&self,
request: Request<tonic::Streaming<LoginRequest>>,
) -> Result<Response<Self::LoginUserStream>, Status> {
println!("Got a login request: {:?}", request);
unimplemented!()
}
async fn get_user_token(
&self,
request: Request<GetUserTokenRequest>,
) -> Result<Response<GetUserTokenResponse>, Status> {
println!("Got a lookup request: {:?}", request);
unimplemented!()
}
}
#[tokio::main]
async fn main() -> Result<(), Box<dyn std::error::Error>> {
let addr = "[::]:50054".parse()?;
let identity_service = MyIdentityService::default();
Server::builder()
.add_service(IdentityServiceServer::new(identity_service))
.serve(addr)
.await?;
Ok(())
} }
View Options

services/comm-services-lib/src/blob/client.rs

fn main() { use futures_core::Stream;
println!("Hello, world!"); use std::pin::Pin;
use tonic::{transport::Server, Request, Response, Status};
use identity::identity_service_server::{IdentityService, IdentityServiceServer};
use identity::{
GetUserTokenRequest, GetUserTokenResponse, LoginRequest, LoginResponse, RegistrationRequest,
RegistrationResponse,
};
pub mod identity {
tonic::include_proto!("identity");
}
#[derive(Debug, Default)]
pub struct MyIdentityService {}
#[tonic::async_trait]
impl IdentityService for MyIdentityService {
type RegisterUserStream =
Pin<Box<dyn Stream<Item = Result<RegistrationResponse, Status>> + Send + 'static>>;
async fn register_user(
&self,
request: Request<tonic::Streaming<RegistrationRequest>>,
) -> Result<Response<Self::RegisterUserStream>, Status> {
println!("Got a registration request: {:?}", request);
unimplemented!()
}
type LoginUserStream =
Pin<Box<dyn Stream<Item = Result<LoginResponse, Status>> + Send + 'static>>;
async fn login_user(
&self,
request: Request<tonic::Streaming<LoginRequest>>,
) -> Result<Response<Self::LoginUserStream>, Status> {
println!("Got a login request: {:?}", request);
unimplemented!()
}
async fn get_user_token(
&self,
request: Request<GetUserTokenRequest>,
) -> Result<Response<GetUserTokenResponse>, Status> {
println!("Got a lookup request: {:?}", request);
unimplemented!()
}
}
#[tokio::main]
async fn main() -> Result<(), Box<dyn std::error::Error>> {
let addr = "[::]:50054".parse()?;
let identity_service = MyIdentityService::default();
Server::builder()
.add_service(IdentityServiceServer::new(identity_service))
.serve(addr)
.await?;
Ok(())
} }