Page MenuHomePhabricator

[keyserver] Introduce `0x` dependency for `keyserver` profiling
ClosedPublic

Authored by atul on Sep 27 2023, 8:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 4:54 PM
Unknown Object (File)
Thu, Nov 14, 9:26 AM
Unknown Object (File)
Thu, Nov 14, 9:26 AM
Unknown Object (File)
Thu, Nov 14, 9:26 AM
Unknown Object (File)
Thu, Nov 14, 9:26 AM
Unknown Object (File)
Thu, Nov 14, 9:25 AM
Unknown Object (File)
Thu, Nov 14, 9:17 AM
Unknown Object (File)
Oct 17 2024, 7:48 PM
Subscribers

Details

Summary

GitHub: https://github.com/davidmarkclements/0x

Suggested in official Node docs: https://nodejs.org/en/docs/guides/diagnostics-flamegraph#use-a-pre-packaged-tool

It was pretty seamless to get this working w/ our project, I was quickly able to generate flamegraphs like:

https://blob.sh/8e38f2.png

Test Plan

NA, just adding dependency

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul published this revision for review.Sep 27 2023, 8:22 AM
atul added reviewers: ashoat, tomek, rohan, ginsu.

Can you make sure CI passes before landing? It looks like you'll need to add some [ignore] lines to some .flowconfigs

This revision is now accepted and ready to land.Sep 27 2023, 9:00 AM
atul edited the test plan for this revision. (Show Details)

ignore .*/node_modules/module-deps/test/invalid_pkg/package.json

Similar to .*/node_modules/resolve/test/resolver/malformed_package_json/package\.json$ which is in the RN .flowconfig this package.json isn't actually a package.json, but rather an intentionally malformed json file used as part of some internal tests. We can just ignore it for now to appease flow.