Paths

Table of Contentst

Differential D9365

[lib/native] lift AvatarSize type into lib
ClosedPublic
Actions

Authored by ginsu on Oct 4 2023, 1:51 PM.

Tags

None

Referenced Files

	F3295909: D9365.id31672.diff
	Sat, Nov 16, 11:49 PM

	F3295659: D9365.id31650.diff
	Sat, Nov 16, 10:33 PM

	F3295591: D9365.id31662.diff
	Sat, Nov 16, 10:18 PM

	Unknown Object (File)
	Thu, Nov 14, 8:12 PM

	Unknown Object (File)
	Thu, Nov 14, 7:26 AM

	Unknown Object (File)
	Thu, Nov 14, 7:26 AM

	Unknown Object (File)
	Thu, Nov 14, 7:26 AM

	Unknown Object (File)
	Thu, Nov 14, 7:25 AM

View All 74 Files

Subscribers

Details

Reviewers

atul
inka

Commits

rCOMMe3557bc1806f: [lib/native] lift AvatarSize type into lib

Summary

This AvatarSize type is only accessible in the native codebase. However, we will need this for web as well so it makes sense to lift this type into lib. This diff just handles the lifting from native to lib, a subsequent diff will handle the actual usage of this type in web

Depends on D9364

Test Plan

flow

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Oct 4 2023, 1:51 PM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 4 2023, 1:51 PM

ginsu edited the summary of this revision. (Show Details)Oct 4 2023, 1:52 PM

ginsu added reviewers: atul, inka.

ginsu added a parent revision: D9364: [native] update avatar size variants to use t-shirt sizes.

ginsu added a child revision: D9366: [lib/native] introduce XXL size to AvatarSize.Oct 4 2023, 1:56 PM

Harbormaster completed remote builds in B22983: Diff 31650.Oct 4 2023, 2:09 PM

ginsu requested review of this revision.Oct 4 2023, 2:09 PM

atul accepted this revision.Oct 4 2023, 5:07 PM

This revision is now accepted and ready to land.Oct 4 2023, 5:07 PM

rebase before landing

Harbormaster completed remote builds in B22995: Diff 31662.Oct 4 2023, 8:39 PM

Closed by commit rCOMMe3557bc1806f: [lib/native] lift AvatarSize type into lib (authored by ginsu). · Explain WhyOct 4 2023, 8:50 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMe3557bc1806f: [lib/native] lift AvatarSize type into lib.

Revision Contents
Changeset List

Path

Size

lib/

types/

avatar-types.js

2 lines

native/

avatars/

avatar.react.js

7 lines

thread-avatar.react.js

3 lines

user-avatar.react.js

7 lines

Diff 31650

lib/types/avatar-types.js

Loading...

native/avatars/avatar.react.js

Loading...

native/avatars/thread-avatar.react.js

Loading...

native/avatars/user-avatar.react.js

Loading...