Page MenuHomePhabricator
Differential D9366

[lib/native] introduce XXL size to AvatarSize
ClosedPublic
Actions

Authored by ginsu on Oct 4 2023, 1:55 PM.
Tags
None
Referenced Files
F3295643: D9366.id31651.diff
Sat, Nov 16, 10:27 PM
F3295402: D9366.id31663.diff
Sat, Nov 16, 9:40 PM
F3294562: D9366.diff
Sat, Nov 16, 7:31 PM
Unknown Object (File)
Thu, Nov 14, 7:26 AM
Unknown Object (File)
Thu, Nov 14, 7:26 AM
Unknown Object (File)
Thu, Nov 14, 7:26 AM
Unknown Object (File)
Thu, Nov 14, 7:25 AM
Unknown Object (File)
Thu, Nov 14, 7:08 AM
View All 74 Files
Subscribers
ashoat
• ted
tomek
will

Details

Reviewers
atul
inka
Commits
rCOMM91da37a13cb2: [lib/native] introduce XXL size to AvatarSize
Summary

For the user profile avatar modal, we need a bigger avatar size (224x224)

Depends on D9365

Test Plan

Confirmed the sizing with @ted, and this is what the avatar will look like:

emoji:

Screenshot 2023-10-04 at 4.14.37 PM.png (1×1 px, 836 KB)

image:

Screenshot 2023-10-04 at 4.14.46 PM.png (1×1 px, 978 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Oct 4 2023, 1:55 PM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 4 2023, 1:55 PM
ginsu edited the summary of this revision. (Show Details)Oct 4 2023, 1:56 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D9365: [lib/native] lift AvatarSize type into lib.
ginsu attached a referenced file: F790092: Screenshot 2023-10-04 at 4.14.46 PM.png. (Show Details)
ginsu attached a referenced file: F790091: Screenshot 2023-10-04 at 4.14.37 PM.png. (Show Details)
Harbormaster completed remote builds in B22984: Diff 31651.Oct 4 2023, 2:12 PM
ginsu requested review of this revision.Oct 4 2023, 2:12 PM
atul accepted this revision.Oct 4 2023, 5:06 PM

Double Extra Large??

408e74.png (1×1 px, 1 MB)

This revision is now accepted and ready to land.Oct 4 2023, 5:06 PM
ginsu added a comment.Oct 4 2023, 8:24 PM
In D9366#275107, @atul wrote:

Double Extra Large??

408e74.png (1×1 px, 1 MB)

lmao

ginsu updated this revision to Diff 31663.Oct 4 2023, 8:25 PM

rebase before landing

Harbormaster completed remote builds in B22996: Diff 31663.Oct 4 2023, 8:42 PM
Closed by commit rCOMM91da37a13cb2: [lib/native] introduce XXL size to AvatarSize (authored by ginsu). · Explain WhyOct 4 2023, 8:50 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM91da37a13cb2: [lib/native] introduce XXL size to AvatarSize.

Revision Contents
Changeset List

PathSize
lib/
types/
2 lines
native/
avatars/
17 lines

Diff 31651

View Options

lib/types/avatar-types.js

Loading...
View Options

native/avatars/avatar.react.js

Loading...