[lib/native] introduce XXL size to AvatarSize
ClosedPublic
Actions

Authored by ginsu on Oct 4 2023, 8:55 PM.

Details

Reviewers

atul
inka

Commits

rCOMM91da37a13cb2: [lib/native] introduce XXL size to AvatarSize

Summary

For the user profile avatar modal, we need a bigger avatar size (224x224)

Depends on D9365

Test Plan

Confirmed the sizing with @ted, and this is what the avatar will look like:

emoji:

Screenshot 2023-10-04 at 4.14.37 PM.png (1×1 px, 836 KB)

image:

Screenshot 2023-10-04 at 4.14.46 PM.png (1×1 px, 978 KB)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Oct 4 2023, 8:55 PM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 4 2023, 8:55 PM

ginsu edited the summary of this revision. (Show Details)Oct 4 2023, 8:56 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, inka.

ginsu added a parent revision: D9365: [lib/native] lift AvatarSize type into lib.

ginsu attached a referenced file: F790092: Screenshot 2023-10-04 at 4.14.46 PM.png. (Show Details)

ginsu attached a referenced file: F790091: Screenshot 2023-10-04 at 4.14.37 PM.png. (Show Details)

Harbormaster completed remote builds in B22984: Diff 31651.Oct 4 2023, 9:12 PM

ginsu requested review of this revision.Oct 4 2023, 9:12 PM

Double Extra Large??

This revision is now accepted and ready to land.Oct 5 2023, 12:06 AM

In D9366#275107, @atul wrote:

Double Extra Large??

lmao

rebase before landing

Harbormaster completed remote builds in B22996: Diff 31663.Oct 5 2023, 3:42 AM

Closed by commit rCOMM91da37a13cb2: [lib/native] introduce XXL size to AvatarSize. · Explain WhyOct 5 2023, 3:50 AM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM91da37a13cb2: [lib/native] introduce XXL size to AvatarSize.

Revision Contents
Changeset List

Path

Size

lib/

types/

avatar-types.js

2 lines

native/

avatars/

avatar.react.js

17 lines

Diff 31663

View Options

lib/types/avatar-types.js