[lib][landing][web] Update patch versions of Rainbowkit and Wagmi
ClosedPublic
Actions

Authored by ashoat on Oct 6 2023, 12:48 PM.

Details

Reviewers

rohan
atul
ginsu

Commits

rCOMM706be3eb01cc: [lib][landing][web] Update patch versions of Rainbowkit and Wagmi

Summary

These updates have no breaking changes. I was testing this during investigation of ENG-5152... it turned out not to be necessary, but I figured I'd diff it up anyways since it's good to have recent package versions.

Test Plan

I deployed these patch versions to my staging keyserver at comm.domains, and then ran a version of the mobile app pointed there. I made sure that SIWE still worked with Rainbow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Oct 6 2023, 12:48 PM

Herald added subscribers: will, tomek. · View Herald TranscriptOct 6 2023, 12:48 PM

Rename patchfile

Harbormaster completed remote builds in B23068: Diff 31758.Oct 6 2023, 1:06 PM

Harbormaster completed remote builds in B23069: Diff 31759.

ashoat requested review of this revision.Oct 6 2023, 1:07 PM

IIRC we were using some CSS selectors from dist that might need to be updated?

EDIT:
These guys:

Maybe they've remained stable if nothing appeared off during testing?

This revision is now accepted and ready to land.Oct 6 2023, 1:10 PM

atul attached a referenced file: F795869: 188d48.png. (Show Details)Oct 6 2023, 1:11 PM

Good call out, thanks for linking them.

Maybe they've remained stable if nothing appeared off during testing?

Yeah, I think so. I checked node_modules/@rainbow-me/rainbowkit/dist/components/index.css and those two CSS selector class names still appeared in there, so I suspect it hasn't changed. RainbowKit's GitHub Releases page also lists each patch in each version bump, and I confirmed none of them touch that CSS file.

Closed by commit rCOMM706be3eb01cc: [lib][landing][web] Update patch versions of Rainbowkit and Wagmi (authored by ashoat). · Explain WhyOct 6 2023, 8:09 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM706be3eb01cc: [lib][landing][web] Update patch versions of Rainbowkit and Wagmi.