[keyserver] implement function to get account prekey and prekey signature
ClosedPublic
Actions

Authored by kamil on Oct 9 2023, 6:58 AM.

Details

Reviewers

varun
marcin
ashoat

Commits

rCOMMab54e7f4f946: [keyserver] implement function to get account prekey and prekey signature

Summary

Issue: ENG-3944.

This is part of D8476 (breaking this for smaller diffs because it's complex).

Extracting code to separate function, will be used later in the stack so this reduces code duplication.

Depends on D9419

Test Plan

Flow, this only moves some code around.

Diff Detail

Repository

rCOMM Comm

Branch

publish-prekey-rotation

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Oct 9 2023, 6:58 AM

kamil held this revision as a draft.

Herald added subscribers: will, tomek. · View Herald TranscriptOct 9 2023, 6:58 AM

fix type

kamil added a child revision: D9421: [keyserver] cron job to refresh account prekeys.Oct 9 2023, 7:03 AM

Harbormaster failed remote builds in B23095: Diff 31797!Oct 9 2023, 7:12 AM

Harbormaster completed remote builds in B23096: Diff 31798.Oct 9 2023, 7:17 AM

kamil published this revision for review.Oct 9 2023, 8:18 AM

marcin accepted this revision.Oct 10 2023, 3:20 AM

This revision is now accepted and ready to land.Oct 10 2023, 3:20 AM

ashoat accepted this revision.Oct 10 2023, 7:35 AM

Closed by commit rCOMMab54e7f4f946: [keyserver] implement function to get account prekey and prekey signature (authored by kamil). · Explain WhyOct 16 2023, 2:16 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMab54e7f4f946: [keyserver] implement function to get account prekey and prekey signature.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

user/

10 lines

utils/

olm-utils.js

12 lines

Diff 31798

View Options

keyserver/src/user/login.js

// @flow		// @flow

		import type { Account as OlmAccount } from '@commapp/olm';
import cluster from 'cluster';		import cluster from 'cluster';
import schedule from 'node-schedule';		import schedule from 'node-schedule';

import { backupDB } from './backups.js';		import { backupDB } from './backups.js';
import { createDailyUpdatesThread } from './daily-updates.js';		import { createDailyUpdatesThread } from './daily-updates.js';
import { updateAndReloadGeoipDB } from './update-geoip-db.js';		import { updateAndReloadGeoipDB } from './update-geoip-db.js';
import { updateIdentityReservedUsernames } from './update-identity-reserved-usernames.js';		import { updateIdentityReservedUsernames } from './update-identity-reserved-usernames.js';
import { deleteOrphanedActivity } from '../deleters/activity-deleters.js';		import { deleteOrphanedActivity } from '../deleters/activity-deleters.js';
Show All 9 Lines	import {
deleteOrphanedSessions,		deleteOrphanedSessions,
deleteOldWebSessions,		deleteOldWebSessions,
} from '../deleters/session-deleters.js';		} from '../deleters/session-deleters.js';
import { deleteStaleSIWENonceEntries } from '../deleters/siwe-nonce-deleters.js';		import { deleteStaleSIWENonceEntries } from '../deleters/siwe-nonce-deleters.js';
import { deleteInaccessibleThreads } from '../deleters/thread-deleters.js';		import { deleteInaccessibleThreads } from '../deleters/thread-deleters.js';
import { deleteExpiredUpdates } from '../deleters/update-deleters.js';		import { deleteExpiredUpdates } from '../deleters/update-deleters.js';
import { deleteUnassignedUploads } from '../deleters/upload-deleters.js';		import { deleteUnassignedUploads } from '../deleters/upload-deleters.js';
import { fetchCallUpdateOlmAccount } from '../updaters/olm-account-updater.js';		import { fetchCallUpdateOlmAccount } from '../updaters/olm-account-updater.js';
import { validateAccountPrekey } from '../utils/olm-utils.js';		import { validateAndUploadAccountPrekeys } from '../utils/olm-utils.js';

if (cluster.isMaster) {		if (cluster.isMaster) {
schedule.scheduleJob(		schedule.scheduleJob(
'30 3 * * *', // every day at 3:30 AM in the keyserver's timezone		'30 3 * * *', // every day at 3:30 AM in the keyserver's timezone
async () => {		async () => {
try {		try {
// Do everything one at a time to reduce load since we're in no hurry,		// Do everything one at a time to reduce load since we're in no hurry,
// and since some queries depend on previous ones.		// and since some queries depend on previous ones.
▲ Show 20 Lines • Show All 69 Lines • ▼ Show 20 Lines	async () => {
);		);
}		}
},		},
);		);
schedule.scheduleJob(		schedule.scheduleJob(
'0 0 * * *', // every day at midnight in the keyserver's timezone		'0 0 * * *', // every day at midnight in the keyserver's timezone
async () => {		async () => {
try {		try {
await fetchCallUpdateOlmAccount('content', validateAccountPrekey);		await fetchCallUpdateOlmAccount(
await fetchCallUpdateOlmAccount('notifications', validateAccountPrekey);		'content',
		(contentAccount: OlmAccount) =>
		fetchCallUpdateOlmAccount(
		'notifications',
		(notifAccount: OlmAccount) =>
		validateAndUploadAccountPrekeys(contentAccount, notifAccount),
		),
		);
} catch (e) {		} catch (e) {
console.warn('encountered error while trying to validate prekeys', e);		console.warn('encountered error while trying to validate prekeys', e);
}		}
},		},
);		);
}		}