Page MenuHomePhabricator
Differential D9422

[keyserver] delete marking prekeys as published each time `olm` account is accessed
ClosedPublic
Actions

Authored by kamil on Oct 9 2023, 7:05 AM.
Tags
None
Referenced Files
F3516646: D9422.id31800.diff
Sun, Dec 22, 3:03 PM
F3516335: D9422.id32029.diff
Sun, Dec 22, 1:56 PM
F3515331: D9422.diff
Sun, Dec 22, 8:31 AM
Unknown Object (File)
Mon, Dec 16, 10:27 AM
Unknown Object (File)
Mon, Dec 16, 10:27 AM
Unknown Object (File)
Sat, Dec 14, 9:01 PM
Unknown Object (File)
Tue, Dec 10, 5:22 PM
Unknown Object (File)
Fri, Nov 29, 6:31 PM
View All 92 Files
Subscribers
tomek
will

Details

Reviewers
varun
marcin
ashoat
Commits
rCOMM5119614a2541: [keyserver] delete marking prekeys as published each time `olm` account is…
Summary

Issue: ENG-3944.

This is part of D8476 (breaking this for smaller diffs because it's complex).

Keys should be marked as published only on:

Depends on D9421

Test Plan

N/A (but tested in previous diff that after actual publishing, keys are marked as published).

Diff Detail

Repository
rCOMM Comm
Branch
publish-prekey-rotation
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Oct 9 2023, 7:05 AM
kamil held this revision as a draft.
Herald added subscribers: will, tomek. · View Herald TranscriptOct 9 2023, 7:05 AM
kamil edited the summary of this revision. (Show Details)Oct 9 2023, 7:05 AM
kamil added a child revision: D9423: [keyserver] validate prekeys only via cron job.Oct 9 2023, 7:06 AM
Harbormaster completed remote builds in B23098: Diff 31800.Oct 9 2023, 7:22 AM
kamil published this revision for review.Oct 9 2023, 8:19 AM
marcin accepted this revision.Oct 10 2023, 3:33 AM
This revision is now accepted and ready to land.Oct 10 2023, 3:33 AM
ashoat accepted this revision.Oct 10 2023, 7:45 AM

I noticed that when Jon was first working on this, he copy-pasted some of @marcin's functions and kept the same name. Since that point, it appears that the copy-pasted functions have diverged. I think we should look to deduplicate them, or maybe have one call the other. We should certainly rename them to have different names if we are going to keep both.

I found retrieveAccountKeysSet to be duplicated like this. I'm not sure, but there may be more. Separately, it looks like there is a lot of code duplication between getOlmSessionInitializationDataResponder and registerOrLogin.

No need to block landing this stack on this – feel free to create a follow-up task or another diff (before landing) if preferred.

kamil mentioned this in D9450: [keyserver] rename `retrieveAccountKeysSet` -> `retrieveSessionInitializationKeysSet`.Oct 11 2023, 6:09 AM
kamil added a comment.Oct 11 2023, 6:11 AM
In D9422#276975, @ashoat wrote:

I noticed that when Jon was first working on this, he copy-pasted some of @marcin's functions and kept the same name. Since that point, it appears that the copy-pasted functions have diverged. I think we should look to deduplicate them, or maybe have one call the other. We should certainly rename them to have different names if we are going to keep both.

I found retrieveAccountKeysSet to be duplicated like this. I'm not sure, but there may be more. Separately, it looks like there is a lot of code duplication between getOlmSessionInitializationDataResponder and registerOrLogin.

No need to block landing this stack on this – feel free to create a follow-up task or another diff (before landing) if preferred.

D9450

Closed by commit rCOMM5119614a2541: [keyserver] delete marking prekeys as published each time `olm` account is… (authored by kamil). · Explain WhyOct 16 2023, 2:16 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM5119614a2541: [keyserver] delete marking prekeys as published each time `olm` account is….
kamil mentioned this in rCOMM38818ef31dfe: [keyserver] rename `retrieveAccountKeysSet` ->….

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
5 lines

Diff 31800

View Options

keyserver/src/responders/keys-responders.js

Loading...