Page MenuHomePhabricator

[landing] Update useMonitorForWalletConnectModal for new WalletConnect modal
ClosedPublic

Authored by ashoat on Oct 9 2023, 1:12 PM.
Tags
None
Referenced Files
F2779364: D9435.id31863.diff
Fri, Sep 20, 10:30 AM
F2779022: D9435.diff
Fri, Sep 20, 8:43 AM
Unknown Object (File)
Tue, Sep 17, 12:08 AM
Unknown Object (File)
Mon, Sep 16, 6:23 PM
Unknown Object (File)
Sun, Sep 15, 1:15 PM
Unknown Object (File)
Sun, Sep 15, 1:15 PM
Unknown Object (File)
Sun, Sep 15, 1:13 PM
Unknown Object (File)
Sun, Sep 15, 12:53 PM
Subscribers

Details

Summary

The WalletConnect modal has been updated, and now the HTML is slightly different.

Depends on D9434

Test Plan

I tested the WalletConnect modal:

  1. Tested iOS and Android physical devices
  2. Tested in a public staging environment (comm.domains)
  3. Tested the QR code scan feature on web
  4. Tested expanding to see "All wallets"
  5. Tested selecting a wallet (Rainbow)
  6. Tested searching for a wallet by typing a query

Some videos of the testing can be seen in the final diff in the stack.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage