Page MenuHomePhabricator
Differential D9439

[lib] Fix render of ConnectedWalletInfo on landing
ClosedPublic
Actions

Authored by ashoat on Oct 9 2023, 6:29 PM.
Tags
None
Referenced Files
F3341869: D9439.id31857.diff
Thu, Nov 21, 11:42 PM
F3338459: D9439.diff
Thu, Nov 21, 6:13 PM
F3332632: D9439.id31848.diff
Thu, Nov 21, 12:36 AM
Unknown Object (File)
Wed, Nov 20, 4:39 PM
Unknown Object (File)
Wed, Nov 20, 4:39 PM
Unknown Object (File)
Wed, Nov 20, 4:39 PM
Unknown Object (File)
Wed, Nov 20, 4:37 PM
Unknown Object (File)
Wed, Nov 20, 4:17 PM
View All 82 Files
Subscribers
tomek
will

Details

Reviewers
rohan
atul
ginsu
Commits
rCOMM3d3e0ed4f78c: [lib] Fix render of ConnectedWalletInfo on landing
Summary

Noticed this looked bad on landing because of this line of reset.css.

Test Plan
beforeafter
Screenshot 2023-10-09 at 9.26.44 PM.png (2×1 px, 1 MB)
Screenshot 2023-10-09 at 9.27.31 PM.png (2×1 px, 1 MB)

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/siwe
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Oct 9 2023, 6:29 PM
Herald added subscribers: will, tomek. · View Herald TranscriptOct 9 2023, 6:29 PM
ashoat added a parent revision: D9438: [landing] Update Lottie packages.Oct 9 2023, 6:29 PM
ashoat edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B23134: Diff 31848.Oct 9 2023, 6:46 PM
ashoat requested review of this revision.Oct 9 2023, 6:46 PM
ashoat updated this revision to Diff 31857.Oct 10 2023, 5:01 AM

Rebase

Harbormaster completed remote builds in B23138: Diff 31857.Oct 10 2023, 5:19 AM
ashoat added a comment.Oct 10 2023, 6:16 AM

Attaching videos here since it's the last diff in the stack:

mobileweb
staging
local
rohan accepted this revision.Oct 10 2023, 6:51 AM

Thanks for the test videos

This revision is now accepted and ready to land.Oct 10 2023, 6:51 AM
Closed by commit rCOMM3d3e0ed4f78c: [lib] Fix render of ConnectedWalletInfo on landing (authored by ashoat). · Explain WhyOct 10 2023, 6:53 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM3d3e0ed4f78c: [lib] Fix render of ConnectedWalletInfo on landing.

Revision Contents
Changeset List

PathSize
lib/
components/
1 line

Diff 31848

View Options

lib/components/connected-wallet-info.css

Loading...