Page MenuHomePhabricator

[keyserver/web] Enable announcement subchannel creation
ClosedPublic

Authored by rohan on Oct 13 2023, 12:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 10:28 PM
Unknown Object (File)
Thu, Nov 7, 9:19 PM
Unknown Object (File)
Thu, Nov 7, 9:19 PM
Unknown Object (File)
Thu, Nov 7, 9:10 PM
Unknown Object (File)
Thu, Nov 7, 7:32 PM
Unknown Object (File)
Oct 6 2024, 3:33 AM
Unknown Object (File)
Oct 6 2024, 1:28 AM
Unknown Object (File)
Oct 1 2024, 9:55 AM
Subscribers

Details

Summary

While working on ENG-5182, I noticed that we prevent subchannel creation to be announcement channels. From an initial investigation, it looks like it's been disabled since D5211. An error is thrown when attempting to create a new subchannel with the announcement setting because it fails the input validation.

Test Plan

Ran yarn workspace lib test (to make sure thread-responders.test.js still worked, and more importantly manually tested creating both an open announcement subchannel and a secret announcement subchannel. The permissions like I mentioned are kind of weird though since non-members of the new secret subchannel can discover it in the navigation drawer, so I'll make it part of my overall permissions fixes for ENG-5182.

Diff Detail

Repository
rCOMM Comm
Branch
ENG-5182
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

rohan requested review of this revision.Oct 13 2023, 1:04 PM
ashoat added inline comments.
web/modals/threads/create/compose-subchannel-modal.react.js
102–106

Do we have anything equivalent on native? Or is it not possible to create an announcement channel on native yet?

This revision is now accepted and ready to land.Oct 16 2023, 1:54 PM
web/modals/threads/create/compose-subchannel-modal.react.js
102–106

Not possible yet I believe, it's tracked in ENG-1887