I noticed that when Jon was first working on this, he copy-pasted some of @marcin's functions and kept the same name. Since that point, it appears that the copy-pasted functions have diverged. I think we should look to deduplicate them, or maybe have one call the other. We should certainly rename them to have different names if we are going to keep both.

I found retrieveAccountKeysSet to be duplicated like this. I'm not sure, but there may be more. Separately, it looks like there is a lot of code duplication between getOlmSessionInitializationDataResponder and registerOrLogin.

No need to block landing this stack on this – feel free to create a follow-up task or another diff (before landing) if preferred.

kamil mentioned this in D9450: [keyserver] rename `retrieveAccountKeysSet` -> `retrieveSessionInitializationKeysSet`.Oct 11 2023, 6:09 AM

In D9422#276975, @ashoat wrote:

I noticed that when Jon was first working on this, he copy-pasted some of @marcin's functions and kept the same name. Since that point, it appears that the copy-pasted functions have diverged. I think we should look to deduplicate them, or maybe have one call the other. We should certainly rename them to have different names if we are going to keep both.

I found retrieveAccountKeysSet to be duplicated like this. I'm not sure, but there may be more. Separately, it looks like there is a lot of code duplication between getOlmSessionInitializationDataResponder and registerOrLogin.

No need to block landing this stack on this – feel free to create a follow-up task or another diff (before landing) if preferred.