Page MenuHomePhabricator
Differential D9474

[identity] Replace usage of Device enum with DeviceType
ClosedPublic
Actions

Authored by will on Oct 12 2023, 3:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 8:25 PM
Unknown Object (File)
Fri, Nov 22, 6:54 PM
Unknown Object (File)
Fri, Nov 22, 6:49 PM
Unknown Object (File)
Thu, Nov 21, 5:48 AM
Unknown Object (File)
Thu, Nov 21, 5:48 AM
Unknown Object (File)
Thu, Nov 21, 5:48 AM
Unknown Object (File)
Thu, Nov 21, 5:48 AM
Unknown Object (File)
Thu, Nov 21, 5:47 AM
View All 65 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
• jon
Commits
rCOMM02ca5ba6efe9: [identity] Replace usage of Device enum with DeviceType
Summary

We can replace the usage of Device in database.rs and client_service.rs with the code generated DeviceType enum.
This reduces code duplication as we have implemented Display and TryFrom traits in shared.

Test Plan

Wrote basic unit tests utilizing try_from in database.rs and cargo builds

Diff Detail

Repository
rCOMM Comm
Branch
wyilio/replace_device_enum
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Oct 12 2023, 3:18 PM
Herald added a reviewer: • jon. · View Herald TranscriptOct 12 2023, 3:18 PM
Herald added subscribers: tomek, ashoat. · View Herald Transcript
Harbormaster completed remote builds in B23222: Diff 31978.Oct 12 2023, 3:37 PM
will requested review of this revision.Oct 12 2023, 3:37 PM
varun accepted this revision.Oct 18 2023, 12:06 PM

this looks great!

This revision is now accepted and ready to land.Oct 18 2023, 12:06 PM
varun added inline comments.Oct 18 2023, 12:08 PM
services/identity/src/database.rs
1564 ↗(On Diff #31978)

let's rename this test something more precise like test_int_to_device_type(). rn it's unclear what we're trying to convert the int to

varun added inline comments.Oct 18 2023, 12:09 PM
services/identity/src/database.rs
75 ↗(On Diff #31978)

DBDeviceTypeInt would be more clear imo

will updated this revision to Diff 32160.Oct 18 2023, 1:28 PM
will marked an inline comment as done.

Rename DBDeviceInt with DBDeviceTypeInt and test name

This revision was landed with ongoing or failed builds.Oct 18 2023, 1:30 PM
Closed by commit rCOMM02ca5ba6efe9: [identity] Replace usage of Device enum with DeviceType (authored by will). · Explain Why
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM02ca5ba6efe9: [identity] Replace usage of Device enum with DeviceType.
Harbormaster completed remote builds in B23340: Diff 32160.Oct 18 2023, 1:46 PM

Revision Contents
Changeset List

PathSize
services/
identity/
src/
14 lines
59 lines

Diff 32160

View Options

services/identity/src/client_service.rs

Loading...
View Options

services/identity/src/database.rs

Loading...