Page MenuHomePhabricator
Differential D9526

[keyserver] add eth addresses to reserved usernames table
ClosedPublic
Actions

Authored by varun on Oct 18 2023, 8:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 4:38 PM
Unknown Object (File)
Wed, Nov 20, 4:38 PM
Unknown Object (File)
Wed, Nov 20, 4:38 PM
Unknown Object (File)
Wed, Nov 20, 4:37 PM
Unknown Object (File)
Wed, Nov 20, 4:18 PM
Unknown Object (File)
Fri, Nov 15, 11:09 AM
Unknown Object (File)
Mon, Nov 11, 5:25 AM
Unknown Object (File)
Fri, Nov 8, 3:41 PM
View All 83 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
ashoat
atul
Commits
rCOMMf7df2484fa4a: [keyserver] add eth addresses to reserved usernames table
Summary

we should add eth addresses to the reserved usernames table as well so we can make sure we don't mint new user IDs for these users

Test Plan

verified eth address exists in my localstack ddb reserved usernames table

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Oct 18 2023, 8:19 PM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 18 2023, 8:19 PM
varun added a child revision: D9527: [identity] dedup Registration and Reserved Username Registration.Oct 18 2023, 8:21 PM
Harbormaster completed remote builds in B23341: Diff 32170.Oct 18 2023, 8:38 PM
varun requested review of this revision.Oct 18 2023, 8:38 PM
ashoat added inline comments.Oct 19 2023, 10:13 AM
keyserver/src/creators/account-creator.js
193–195 ↗(On Diff #32170)

Not clear you need this async IIFE anymore (see below comment)

294–298 ↗(On Diff #32170)

Not clear to me why you need this async IIFE

varun updated this revision to Diff 32248.Oct 20 2023, 7:07 AM

remove unnecessary iife's

varun edited reviewers, added: ashoat, atul; removed: bartek, michal.Oct 20 2023, 7:08 AM
Harbormaster completed remote builds in B23398: Diff 32248.Oct 20 2023, 7:26 AM
atul accepted this revision.Oct 20 2023, 10:54 AM

What happens if the API request fails (eg endpoint is unreachable)? We may end up in a state where not all eth addresses make it to the reserved usernames table.

Should we also have some sort of cron script that takes all eth addresses from keyserver DB and hits the addReservedUsernames endpoint to "fix things up" so things are eventually in a correct state?

This revision is now accepted and ready to land.Oct 20 2023, 10:54 AM
varun added a comment.Oct 20 2023, 10:56 AM
In D9526#280196, @atul wrote:

What happens if the API request fails (eg endpoint is unreachable)? We may end up in a state where not all eth addresses make it to the reserved usernames table.

Should we also have some sort of cron script that takes all eth addresses from keyserver DB and hits the addReservedUsernames endpoint to "fix things up" so things are eventually in a correct state?

yep that's what keyserver/src/cron/update-identity-reserved-usernames.js does

Closed by commit rCOMMf7df2484fa4a: [keyserver] add eth addresses to reserved usernames table (authored by varun). · Explain WhyOct 20 2023, 11:00 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMf7df2484fa4a: [keyserver] add eth addresses to reserved usernames table.

Revision Contents
Changeset List

PathSize
keyserver/
src/
creators/
41 lines
cron/
6 lines

Diff 32248

View Options

keyserver/src/creators/account-creator.js

Loading...
View Options

keyserver/src/cron/update-identity-reserved-usernames.js

Loading...