Page MenuHomePhabricator
Differential D9331

[lib] Move test messages outside of the describe scope to reuse them
ClosedPublic
Actions

Authored by rohan on Sep 29 2023, 11:08 AM.
Tags
None
Referenced Files
F3369044: D9331.id31551.diff
Mon, Nov 25, 9:31 PM
F3368406: D9331.diff
Mon, Nov 25, 7:43 PM
Unknown Object (File)
Wed, Nov 20, 4:38 PM
Unknown Object (File)
Wed, Nov 20, 4:38 PM
Unknown Object (File)
Wed, Nov 20, 4:38 PM
Unknown Object (File)
Wed, Nov 20, 4:37 PM
Unknown Object (File)
Wed, Nov 20, 4:18 PM
Unknown Object (File)
Tue, Nov 19, 7:48 PM
View All 78 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
ginsu
Commits
rCOMM67624a7d12c7: [lib] Move test messages outside of the describe scope to reuse them
Summary

Just moving the test messages outside of the sceop of the describe block so I can reuse them for the upcoming tests for the pinned messages

Depends on D9330

Resolves https://linear.app/comm/issue/ENG-5210/move-test-messages-outside-of-the-describe-scope-to-reuse-them

Test Plan

Ran flow and yarn workspace lib test

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rohan created this revision.Sep 29 2023, 11:08 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 29 2023, 11:08 AM
rohan edited the summary of this revision. (Show Details)Sep 29 2023, 11:09 AM
rohan added a parent revision: D9330: [keyserver/lib] Update isInvalidSidebarSource to check messageSpec.canBeSidebarSource.
Harbormaster completed remote builds in B22917: Diff 31551.Sep 29 2023, 11:25 AM
rohan requested review of this revision.Sep 29 2023, 11:25 AM
atul accepted this revision.Sep 29 2023, 1:12 PM

might make further sense to pull out to separate test data file?

This revision is now accepted and ready to land.Sep 29 2023, 1:12 PM
rohan added a comment.Oct 3 2023, 9:22 AM
In D9331#274297, @atul wrote:

might make further sense to pull out to separate test data file?

Yeah it would make it easier, I'll probably do that after landing since I could also import them into the message ops utils tests

rohan updated this revision to Diff 31876.Oct 10 2023, 7:59 AM

Rebase

Harbormaster completed remote builds in B23149: Diff 31876.Oct 10 2023, 8:21 AM
rohan added a child revision: D9444: [lib] Introduce a canBePinned boolean to message specs.Oct 10 2023, 8:38 AM
rohan edited the summary of this revision. (Show Details)Oct 10 2023, 9:00 AM
Closed by commit rCOMM67624a7d12c7: [lib] Move test messages outside of the describe scope to reuse them (authored by rohan). · Explain WhyOct 20 2023, 8:27 AM
This revision was automatically updated to reflect the committed changes.
rohan added a commit: rCOMM67624a7d12c7: [lib] Move test messages outside of the describe scope to reuse them.

Revision Contents
Changeset List

PathSize
lib/
shared/
459 lines

Diff 32254

View Options

lib/shared/message-utils.test.js

Loading...