Paths

Table of Contentst

Differential D9536

[lib] Introduce a canBeRenderedOnItsOwn boolean to message specs
ClosedPublic
Actions

Authored by rohan on Oct 19 2023, 6:14 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 8, 3:17 PM

	Unknown Object (File)
	Sat, Oct 19, 4:20 AM

	Unknown Object (File)
	Sat, Oct 19, 4:20 AM

	Unknown Object (File)
	Sat, Oct 19, 4:20 AM

	Unknown Object (File)
	Sat, Oct 19, 4:18 AM

	Unknown Object (File)
	Sat, Oct 19, 4:02 AM

	Unknown Object (File)
	Sep 23 2024, 5:13 AM

	Unknown Object (File)
	Sep 15 2024, 1:14 PM

View All 63 Files

Subscribers

Details

Reviewers

atul
ginsu

Commits

rCOMM6dd7538807f7: [lib] Introduce a canBeRenderedOnItsOwn boolean to message specs

Summary

Now that I've introduced flags for determining sidebar sources / pin sources, the last two steps for ENG-4849 are about refining existing code. Primarily message-fetchers.js code. Taking a look at rawMessageInfoForRowsAndRelatedMessages, we filter out SIDEBAR_SOURCE, TOGGLE_PIN, REACTION and EDIT_MESSAGE. To make this cleaner, we can simplify this since search results will only show TEXT messages, and it's not possible to pin SIDEBAR_SOURCE or TOGGLE_PIN. This new flag, canBeRenderedOnItsOwn, will be set for REACTION and EDIT_MESSAGE, and we'll now check the message specs in the next diff to clean up this code.

Resolves https://linear.app/comm/issue/ENG-5216/introduce-a-canberenderedonitsown-boolean-to-message-specs

Depends on D9445

Test Plan

Updated unit tests, ran yarn workspace lib test, and verified that nothing crashes after introducing a new flag to the message specs

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rohan created this revision.Oct 19 2023, 6:14 AM

rohan held this revision as a draft.

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 19 2023, 6:14 AM

rohan added a child revision: D9537: [keyserver/lib] Update rawMessageInfoForRowsAndRelatedMessages to check for canBeRenderedOnItsOwn.Oct 19 2023, 6:22 AM

Harbormaster completed remote builds in B23360: Diff 32194.Oct 19 2023, 6:32 AM

rohan published this revision for review.Oct 19 2023, 7:49 AM

Looks good, thanks for proactively including unit tests

canBeRenderedOnItsOwn => canBeRenderedIndependently?

8d5387.png (376×1 px, 79 KB)

It is longer, but less words?

atul accepted this revision.Oct 19 2023, 11:29 AM

This revision is now accepted and ready to land.Oct 19 2023, 11:29 AM

canBeRenderedOnItsOwn --> canBeRenderedIndependently

Harbormaster completed remote builds in B23377: Diff 32224.Oct 19 2023, 11:53 AM

Closed by commit rCOMM6dd7538807f7: [lib] Introduce a canBeRenderedOnItsOwn boolean to message specs (authored by rohan). · Explain WhyOct 20 2023, 8:27 AM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMM6dd7538807f7: [lib] Introduce a canBeRenderedOnItsOwn boolean to message specs.

Revision Contents
Changeset List

Path

Size

lib/

shared/

message-utils.test.js

18 lines

messages/

edit-message-spec.js

2 lines

message-spec.js

1 line

reaction-message-spec.js

2 lines

Diff 32257

lib/shared/message-utils.test.js

Loading...

lib/shared/messages/edit-message-spec.js

Loading...

lib/shared/messages/message-spec.js

Loading...

lib/shared/messages/reaction-message-spec.js

Loading...