Page MenuHomePhabricator

[lib] Introduce a canBePinned boolean to message specs
ClosedPublic

Authored by rohan on Oct 10 2023, 8:38 AM.
Tags
None
Referenced Files
F4958038: D9444.diff
Sat, Mar 22, 8:52 PM
Unknown Object (File)
Wed, Mar 19, 1:06 PM
Unknown Object (File)
Thu, Mar 6, 6:28 AM
Unknown Object (File)
Mon, Mar 3, 10:23 PM
Unknown Object (File)
Tue, Feb 25, 8:27 PM
Unknown Object (File)
Tue, Feb 25, 8:27 PM
Unknown Object (File)
Tue, Feb 25, 8:26 PM
Unknown Object (File)
Tue, Feb 25, 8:05 PM
Subscribers

Details

Summary

This diff introduces a canBePinned boolean to each of the message specs, isolating the 'source of truth' to the message specs. The next diff will have a function that will be able to read each of these, alongside unit tests and updating appropriate callsites.

Only composable message types can be pinned

Resolves https://linear.app/comm/issue/ENG-5213/introduce-a-canbepinned-boolean-to-message-specs

Depends on D9331

Test Plan

Ran flow for this diff, more thorough testing will be in the next diff

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable