Page MenuHomePhabricator
Differential D9583

[web] introduce light mode to danger zone component
ClosedPublic
Actions

Authored by ginsu on Oct 24 2023, 12:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 12:46 PM
Unknown Object (File)
Wed, Nov 13, 1:24 PM
Unknown Object (File)
Wed, Nov 13, 1:24 PM
Unknown Object (File)
Wed, Nov 13, 1:23 PM
Unknown Object (File)
Wed, Nov 13, 1:23 PM
Unknown Object (File)
Wed, Nov 13, 1:20 PM
Unknown Object (File)
Oct 12 2024, 7:56 AM
Unknown Object (File)
Oct 12 2024, 7:56 AM
View All 77 Files
Subscribers
ashoat
• ted
tomek
will

Details

Reviewers
atul
inka
rohan
Commits
rCOMM558aef52fb7e: [web] introduce light mode to danger zone component
Summary

This diff introduces the new color design system/light mode to the danger zone component

For additional context about this new color design system and the new naming convention here is the notion doc, @ted and I wrote:
https://www.notion.so/commapp/New-Color-System-Proposal-ef80b4e4b9ec42949095056161223a42

Here is the WIP spreadsheet @ted and I have been using as our source of truth of what we should use as color variables and their associated values
https://docs.google.com/spreadsheets/d/1PwdxT8Ag_4AGzmGSj2wXsR5-go9rsgZvTZycpy3e49k/edit#gid=0

Linear task: https://linear.app/comm/issue/ENG-4803/danger-zone

Depends on D9582

Test Plan

Please see the screenshots below

dark:

Screenshot 2023-10-24 at 4.00.46 PM.png (2×3 px, 715 KB)

light:

Screenshot 2023-10-24 at 4.00.54 PM.png (2×3 px, 720 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Oct 24 2023, 12:57 PM
Herald added subscribers: will, • ted, tomek, ashoat. · View Herald TranscriptOct 24 2023, 12:57 PM
ginsu edited the summary of this revision. (Show Details)Oct 24 2023, 1:01 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added a parent revision: D9582: [web] introduce light mode to the account settings screen.
ginsu attached a referenced file: F835600: Screenshot 2023-10-24 at 4.00.54 PM.png. (Show Details)
ginsu attached a referenced file: F835601: Screenshot 2023-10-24 at 4.00.46 PM.png. (Show Details)
ginsu added reviewers: atul, inka, rohan.
Harbormaster completed remote builds in B23457: Diff 32357.Oct 24 2023, 1:16 PM
ginsu requested review of this revision.Oct 24 2023, 1:16 PM
atul accepted this revision.Oct 24 2023, 4:03 PM
This revision is now accepted and ready to land.Oct 24 2023, 4:03 PM
ginsu updated this revision to Diff 32378.Oct 24 2023, 7:45 PM

rebase before landing

Harbormaster completed remote builds in B23473: Diff 32378.Oct 24 2023, 8:07 PM
Closed by commit rCOMM558aef52fb7e: [web] introduce light mode to danger zone component (authored by ginsu). · Explain WhyOct 24 2023, 8:09 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM558aef52fb7e: [web] introduce light mode to danger zone component.

Revision Contents
Changeset List

PathSize
web/
settings/
11 lines
30 lines
4 lines

Diff 32357

View Options

web/settings/danger-zone.css

Loading...
View Options

web/settings/danger-zone.react.js

Loading...
View Options

web/theme.css

Loading...