Page MenuHomePhabricator
Differential D9566

[native] introduce barebones keyserver selection list screen
ClosedPublic
Actions

Authored by ginsu on Oct 23 2023, 11:21 AM.
Tags
None
Referenced Files
F3408235: D9566.id32365.diff
Wed, Dec 4, 10:31 AM
F3408191: D9566.id32361.diff
Wed, Dec 4, 10:17 AM
F3408175: D9566.id32330.diff
Wed, Dec 4, 10:12 AM
F3405839: D9566.diff
Tue, Dec 3, 11:14 PM
Unknown Object (File)
Fri, Nov 15, 7:07 PM
Unknown Object (File)
Fri, Nov 15, 8:05 AM
Unknown Object (File)
Fri, Nov 15, 8:05 AM
Unknown Object (File)
Fri, Nov 15, 8:05 AM
View All 63 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
rohan
inka
michal
Commits
rCOMMa5d69348e54d: [native] introduce barebones keyserver selection list screen
Summary

This diff introduces the barebones keyserver selection list screen and all the navigation logic to navigate from the profile screen to this new screen

Linear Task: https://linear.app/comm/issue/ENG-4911/introduce-keyserver-selection-screen-into-our-profile-app-navigation

Depends on D9565

Test Plan

Please see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Oct 23 2023, 11:21 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 23 2023, 11:21 AM
ginsu published this revision for review.Oct 23 2023, 11:24 AM
ginsu edited the summary of this revision. (Show Details)
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: rohan, inka, michal.
ginsu added a parent revision: D9565: [native] introduce Keyserver selection settings panel in user settings.
ginsu attached a referenced file: F834123: Screen Recording 2023-10-23 at 2.23.35 PM.mov. (Show Details)
Harbormaster completed remote builds in B23433: Diff 32330.Oct 23 2023, 11:39 AM
rohan accepted this revision.Oct 24 2023, 11:08 AM
This revision is now accepted and ready to land.Oct 24 2023, 11:08 AM
ginsu updated this revision to Diff 32361.Oct 24 2023, 1:29 PM

rebase before landing

Harbormaster completed remote builds in B23461: Diff 32361.Oct 24 2023, 2:36 PM
Closed by commit rCOMMa5d69348e54d: [native] introduce barebones keyserver selection list screen (authored by ginsu). · Explain WhyOct 24 2023, 2:42 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMa5d69348e54d: [native] introduce barebones keyserver selection list screen.

Revision Contents
Changeset List

PathSize
native/
navigation/
2 lines
profile/
10 lines
3 lines
8 lines

Diff 32365

View Options

native/navigation/route-names.js

Loading...
View Options

native/profile/keyserver-selection-list.react.js

Loading...
View Options

native/profile/profile-screen.react.js

Loading...
View Options

native/profile/profile.react.js

Loading...