In the keyserver selection screen we want to add an add button to the right header. I noticed that the Linked devices screen also has the same thing, so as a preliminary step to introducing the add button to the keyserver selection screen, I factored out the shared logic of this button so that it can be used in both places
Details
Details
- Reviewers
rohan inka michal - Commits
- rCOMMf5429de51d2c: [native] introduce HeaderRightTextButton
flow and confirmed that the add button in the linked devices screen still works as expected
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
native/navigation/header-right-add-button.react.js | ||
---|---|---|
26 ↗ | (On Diff #32363) | I should point out that I updated the color here. In the designs for the keyserver selection screen, this button is purple: I spoke to ted about this, and he said that we should update the add button in the linked devices to also be purple and this will make it more consistent with other header right buttons found in our app |
native/navigation/header-right-text-button.react.js | ||
---|---|---|
27 ↗ | (On Diff #32373) | I should point out that I updated the color here. In the designs for the keyserver selection screen, this button is purple: I spoke to ted about this, and he said that we should update the add button in the linked devices to also be purple and this will make it more consistent with other header right buttons found in our app |