Page MenuHomePhabricator

[native] introduce HeaderRightTextButton
ClosedPublic

Authored by ginsu on Oct 24 2023, 2:13 PM.
Tags
None
Referenced Files
F3375457: D9586.diff
Tue, Nov 26, 8:19 PM
Unknown Object (File)
Sat, Nov 23, 7:00 AM
Unknown Object (File)
Sat, Nov 23, 6:56 AM
Unknown Object (File)
Sat, Nov 16, 4:42 AM
Unknown Object (File)
Thu, Nov 14, 11:33 PM
Unknown Object (File)
Thu, Nov 14, 5:47 PM
Unknown Object (File)
Fri, Nov 8, 3:54 PM
Unknown Object (File)
Mon, Oct 28, 12:14 AM
Subscribers

Details

Summary

In the keyserver selection screen we want to add an add button to the right header. I noticed that the Linked devices screen also has the same thing, so as a preliminary step to introducing the add button to the keyserver selection screen, I factored out the shared logic of this button so that it can be used in both places

Test Plan

flow and confirmed that the add button in the linked devices screen still works as expected

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

native/navigation/header-right-add-button.react.js
26 ↗(On Diff #32363)

I should point out that I updated the color here. In the designs for the keyserver selection screen, this button is purple:

Screenshot 2023-10-24 at 4.54.12 PM.png (1×872 px, 127 KB)

I spoke to ted about this, and he said that we should update the add button in the linked devices to also be purple and this will make it more consistent with other header right buttons found in our app

Screenshot 2023-10-24 at 4.53.19 PM.png (1×1 px, 788 KB)

ginsu requested review of this revision.Oct 24 2023, 2:32 PM
native/navigation/header-right-text-button.react.js
27 ↗(On Diff #32373)

I should point out that I updated the color here. In the designs for the keyserver selection screen, this button is purple:

Screenshot 2023-10-24 at 4.54.12 PM.png (1×872 px, 127 KB)

I spoke to ted about this, and he said that we should update the add button in the linked devices to also be purple and this will make it more consistent with other header right buttons found in our app

Screenshot 2023-10-24 at 4.53.19 PM.png (1×1 px, 788 KB)

ginsu retitled this revision from [native] introduce HeaderRightAddButton to [native] introduce HeaderRightTextButton.Oct 24 2023, 4:38 PM
This revision is now accepted and ready to land.Oct 26 2023, 8:32 AM
This revision was automatically updated to reflect the committed changes.