Page MenuHomePhabricator

[lib] Avoid unnecessary Set construction in RadixTree.getAllMatchingExactly
ClosedPublic

Authored by ashoat on Oct 31 2023, 5:05 AM.
Tags
None
Referenced Files
F3192649: D9647.id32541.diff
Fri, Nov 8, 10:04 PM
F3192648: D9647.id32532.diff
Fri, Nov 8, 10:04 PM
F3192519: D9647.id.diff
Fri, Nov 8, 10:01 PM
Unknown Object (File)
Tue, Nov 5, 2:13 AM
Unknown Object (File)
Oct 2 2024, 2:25 PM
Unknown Object (File)
Oct 2 2024, 2:25 PM
Unknown Object (File)
Oct 2 2024, 2:25 PM
Unknown Object (File)
Oct 2 2024, 2:22 PM
Subscribers

Details

Summary

Noticed this after landing the diff here. The underlying data is a Set anyways, so all this does it copy the Set. We don't return the original Set anyways, so there is no point to this.

Depends on D9646

Test Plan

Flow, careful code inspection

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage