Page MenuHomePhabricator
Differential D9672

[web] add client interceptors for grpc-web
ClosedPublic
Actions

Authored by varun on Nov 1 2023, 6:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 20, 3:34 PM
Unknown Object (File)
Mon, Jan 20, 3:34 PM
Unknown Object (File)
Mon, Jan 20, 3:34 PM
Unknown Object (File)
Mon, Jan 20, 3:32 PM
Unknown Object (File)
Fri, Jan 17, 2:57 PM
Unknown Object (File)
Thu, Dec 26, 9:43 PM
Unknown Object (File)
Dec 16 2024, 4:15 PM
Unknown Object (File)
Dec 16 2024, 4:15 PM
View All 56 Files
Subscribers
bartek
tomek
will

Details

Reviewers
ashoat
Commits
rCOMM77a705c2c456: [web] add client interceptors for grpc-web
Summary

these interceptors will be used to add version and auth metadata to our RPCs.

Depends on D9671

Test Plan

https://gist.github.com/vdhanan/15ffc5810425b8a22b7d3c5bd01a8d58

Diff Detail

Repository
rCOMM Comm
Branch
grpc-web (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Nov 1 2023, 6:30 PM
Herald added subscribers: will, tomek. · View Herald TranscriptNov 1 2023, 6:30 PM
Harbormaster completed remote builds in B23654: Diff 32605.Nov 1 2023, 6:58 PM
varun requested review of this revision.Nov 1 2023, 6:58 PM
ashoat accepted this revision.Nov 2 2023, 6:54 AM
ashoat mentioned this in D9671: [web] add flow types for grpc-web unary interceptor.

JS code looks fine but I don't really know anything about gRPC interceptors... should somebody else with context on those review this as well?

This revision is now accepted and ready to land.Nov 2 2023, 6:55 AM
varun added a subscriber: bartek.EditedNov 2 2023, 10:05 AM
In D9672#283058, @ashoat wrote:

JS code looks fine but I don't really know anything about gRPC interceptors... should somebody else with context on those review this as well?

i think @bartek is the only other person with context on interceptors and he's out the rest of the week. i think it's ok to proceed without further review since this code is pretty straightforward and has been tested extensively

Closed by commit rCOMM77a705c2c456: [web] add client interceptors for grpc-web (authored by varun). · Explain WhyNov 8 2023, 12:09 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM77a705c2c456: [web] add client interceptors for grpc-web.

Revision Contents
Changeset List

PathSize
web/
grpc/
53 lines

Diff 32605

View Options

web/grpc/interceptor.js

Loading...