Page MenuHomePhabricator
Differential D9808

[lib] Move minimallyEncodedPermissions types/type utils to separate file
ClosedPublic
Actions

Authored by atul on Nov 9 2023, 1:08 PM.
Tags
None
Referenced Files
F3246579: D9808.diff
Fri, Nov 15, 12:46 AM
Unknown Object (File)
Oct 15 2024, 1:19 AM
Unknown Object (File)
Oct 15 2024, 1:19 AM
Unknown Object (File)
Oct 15 2024, 1:19 AM
Unknown Object (File)
Oct 15 2024, 1:19 AM
Unknown Object (File)
Oct 15 2024, 1:19 AM
Unknown Object (File)
Oct 15 2024, 1:15 AM
Unknown Object (File)
Oct 2 2024, 10:07 PM
View All 64 Files
Subscribers
will

Details

Reviewers
ashoat
ginsu
tomek
rohan
Commits
rCOMM1669fb7522c1: [lib] Move minimallyEncodedPermissions types/type utils to separate file
Summary

This is an attempt to resolve circular dependency issue...

Test Plan

Hopefully will be able to proceed without Jest import issues. Will resolve merge conflicts and then HOPEFULLY will be able to put up refactoring diffs.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Nov 9 2023, 1:08 PM
Herald added a subscriber: will. · View Herald TranscriptNov 9 2023, 1:08 PM
atul updated this revision to Diff 33034.Nov 9 2023, 1:08 PM

include all

atul added a child revision: D9809: [lib] Just cut/paste values into `minimallyEncoded` validators.Nov 9 2023, 1:20 PM
atul published this revision for review.Nov 9 2023, 1:20 PM
Harbormaster completed remote builds in B23975: Diff 33033.Nov 9 2023, 1:29 PM
ashoat accepted this revision.Nov 9 2023, 1:35 PM

Didn't really review... assuming this is just a move

lib/types/minimally-encoded-thread-permissions-types.js
28

What are these about?

This revision is now accepted and ready to land.Nov 9 2023, 1:35 PM
atul added inline comments.Nov 9 2023, 1:37 PM
lib/types/minimally-encoded-thread-permissions-types.js
28

Just to break things apart visually, found them useful to navigate but will go ahead and remove before landing

Harbormaster completed remote builds in B23976: Diff 33034.Nov 9 2023, 1:39 PM
atul updated this revision to Diff 33097.Nov 11 2023, 12:49 PM

remove comments

This revision was landed with ongoing or failed builds.Nov 11 2023, 12:54 PM
Closed by commit rCOMM1669fb7522c1: [lib] Move minimallyEncodedPermissions types/type utils to separate file (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM1669fb7522c1: [lib] Move minimallyEncodedPermissions types/type utils to separate file.
Harbormaster completed remote builds in B24021: Diff 33097.Nov 11 2023, 1:09 PM

Revision Contents
Changeset List

Diff 33034

View Options

lib/permissions/minimally-encoded-thread-permissions-test-data.js

Loading...
View Options

lib/permissions/minimally-encoded-thread-permissions.js

Loading...
View Options

lib/permissions/minimally-encoded-thread-permissions.test.js

Loading...
View Options

lib/types/minimally-encoded-thread-permissions-types.js

Loading...