[lib] Update `threadHasPermission` to support `MinimallyEncodedRawThreadInfo`
ClosedPublic
Actions

Authored by atul on Nov 9 2023, 1:27 PM.

Details

Reviewers

ashoat
ginsu
tomek
rohan

Commits

rCOMM3fa4720b1ea2: [lib] Update `threadHasPermission` to support `MinimallyEncodedRawThreadInfo`

Summary

Update threadHasPermission in thread-utils to support MinimallyEncodedRawThreadInfo via .minimallyEncoded and hasPermission check.

Going to go ahead and do a refactor of a bunch of utils in thread-utils all at once, but will separate out the more "important" ones(?) into their own diffs

Depends on D9809

Test Plan

Will write unit tests once all the Flow stuff is figured out.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Nov 9 2023, 1:27 PM

Herald added a subscriber: will. · View Herald TranscriptNov 9 2023, 1:27 PM

atul published this revision for review.Nov 9 2023, 1:27 PM

ashoat accepted this revision.Nov 9 2023, 1:38 PM

This revision is now accepted and ready to land.Nov 9 2023, 1:38 PM

atul added a child revision: D9811: [lib] Update signatures of thread utils to handle `MinimallyEncodedRawThreadInfo`.Nov 9 2023, 1:47 PM

Harbormaster failed remote builds in B23978: Diff 33036!Nov 9 2023, 2:16 PM

Harbormaster completed remote builds in B23978: Diff 33036.Nov 9 2023, 2:21 PM

Closed by commit rCOMM3fa4720b1ea2: [lib] Update `threadHasPermission` to support `MinimallyEncodedRawThreadInfo` (authored by atul). · Explain WhyNov 11 2023, 12:54 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM3fa4720b1ea2: [lib] Update `threadHasPermission` to support `MinimallyEncodedRawThreadInfo`.

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

12 lines

Diff 33100

View Options

lib/shared/thread-utils.js

				div.membersContainer {
				display: flex;
				flex-direction: column;
				overflow: hidden;
				margin: 16px;
				}

	div.membersList {			div.membersList {
	overflow: scroll;			overflow: scroll;
	padding: 8px 0;			padding: 8px 0;
	color: var(--members-modal-member-text);			color: var(--members-modal-member-text);
	}			}

	div.noScroll {			div.noScroll {
	overflow: hidden;			overflow: hidden;
	Show All 38 Lines

[lib] Update `threadHasPermission` to support `MinimallyEncodedRawThreadInfo`ClosedPublicActions