Page MenuHomePhabricator

[web] introduce new --shades-black-90
ClosedPublic

Authored by ginsu on Nov 8 2023, 3:02 PM.
Tags
None
Referenced Files
F6313190: D9790.id33104.diff
Sat, Apr 26, 12:49 PM
Unknown Object (File)
Wed, Apr 9, 12:55 AM
Unknown Object (File)
Tue, Apr 8, 10:35 PM
Unknown Object (File)
Tue, Apr 8, 10:30 PM
Unknown Object (File)
Tue, Apr 8, 10:20 PM
Unknown Object (File)
Tue, Apr 8, 9:54 PM
Unknown Object (File)
Mon, Apr 7, 5:54 AM
Unknown Object (File)
Sun, Apr 6, 9:19 AM
Subscribers

Details

Summary

This diff introduces a new --shades-black-90. The #191919 color is right now only used in one place so it never got a shade; however, the keyserver selection bottom sheet will use this + a lot of the web app redesign is going to use this color, so I think it makes sense to make this an official shade now.

Here is a screenshot to the new shades of black in the 2023 design system:

Screenshot 2023-11-08 at 6.22.00 PM.png (624×1 px, 51 KB)

Here is the figma doc: https://www.figma.com/file/fwKJ6eNgfxlx8a7WxSyAZL/2023-Design-System?type=design&node-id=1-426&mode=design

I still need to update the figma, but I want to do this after this diff gets accepted in case I need to make changes to this, but here is a task to track that
https://linear.app/comm/issue/DES-159/update-shades-of-black-in-figma

Depends on D9789

Test Plan

flow + went through the app to confirm that there were no regressions

This diff was handled using my code editor find + replace feature. Read through every value and all shades except for shades-black-100 should be decremented by 10

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

desktop/scrollbar.css
8–9 ↗(On Diff #32981)
web/modals/chat/message-results-modal.css
7 ↗(On Diff #32981)
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka, rohan.
ginsu published this revision for review.Nov 8 2023, 3:28 PM

Same concerns as I laid out in D9789

ashoat requested changes to this revision.Nov 9 2023, 3:45 AM
This revision now requires changes to proceed.Nov 9 2023, 3:45 AM
desktop/scrollbar.css
5
web/modals/chat/message-results-modal.css
7

Glazed through most of this, trusting you did the find-replaces correctly

This revision is now accepted and ready to land.Nov 11 2023, 11:00 AM
This revision was landed with ongoing or failed builds.Nov 12 2023, 7:48 PM
This revision was automatically updated to reflect the committed changes.