[lib] Resolve circular dependency issue w/ `MinimallyEncoded*Info` validators
ClosedPublic
Actions

Authored by atul on Nov 10 2023, 1:09 PM.

Details

Reviewers

ashoat
ginsu
tomek
rohan

Commits

rCOMMfc6569af43d8: [lib] Resolve circular dependency issue w/ `MinimallyEncoded*Info` validators

Summary

Moving the regex validators to main minimally-encoded-thread-permissions file makes the validator file a "leaf node" (except for tests) and resolves the circular dependency issue. Also updated validators to spread in base validators.

Depends on D9811

Test Plan

Jest tests run without issue

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Nov 10 2023, 1:09 PM

Herald added a subscriber: will. · View Herald TranscriptNov 10 2023, 1:10 PM

atul published this revision for review.Nov 10 2023, 1:22 PM

atul mentioned this in D9809: [lib] Just cut/paste values into `minimallyEncoded` validators.

Harbormaster completed remote builds in B24010: Diff 33085.Nov 10 2023, 1:44 PM

ashoat accepted this revision.Nov 11 2023, 10:57 AM

This revision is now accepted and ready to land.Nov 11 2023, 10:57 AM

Closed by commit rCOMMfc6569af43d8: [lib] Resolve circular dependency issue w/ `MinimallyEncoded*Info` validators (authored by atul). · Explain WhyNov 11 2023, 12:54 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMfc6569af43d8: [lib] Resolve circular dependency issue w/ `MinimallyEncoded*Info` validators.

Revision Contents
Changeset List

Path

Size

lib/

permissions/

minimally-encoded-thread-permissions.js

7 lines

types/

minimally-encoded-thread-permissions-types.js

44 lines

Diff 33085

View Options

lib/permissions/minimally-encoded-thread-permissions.js