[lib] Introduce `getMinimallyEncodedCurrentUser`
ClosedPublic
Actions

Authored by atul on Nov 13 2023, 10:47 AM.

Details

Reviewers

ashoat
ginsu
tomek
rohan

Commits

rCOMM00f2222fe0dc: [lib] Introduce `getMinimallyEncodedCurrentUser`

Summary

Unfortunately was not able to update getCurrentUser to handle both ThreadInfo|RawThreadInfo AND MinimallyEncodedRawThreadInfo while keeping flow happy.

Here was where I ended up in my attempts:
https://gist.github.com/atulsmadhugiri/cdaa18c6883a5636d1e035b520c47e79#file-blah-js

Fortunately, getCurrentUser info is only used in two places in thread-utils and those can be updated with minimallyEncoded toggle.

Depends on D9839

Test Plan

Will add unit tests once Flow issues are resolved.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Nov 13 2023, 10:47 AM

Herald added a subscriber: will. · View Herald TranscriptNov 13 2023, 10:47 AM

atul published this revision for review.Nov 13 2023, 10:47 AM

Harbormaster completed remote builds in B24046: Diff 33133.Nov 13 2023, 11:06 AM

atul added a child revision: D9841: [lib] Update `threadMemberHasPermission` to support `MinimallyEncodedRawThreadInfo`.Nov 13 2023, 11:19 AM

These diffs are hard to review because I can't tell where this is going to be used. Please be extra careful with your work

This revision is now accepted and ready to land.Nov 13 2023, 12:16 PM

Closed by commit rCOMM00f2222fe0dc: [lib] Introduce `getMinimallyEncodedCurrentUser` (authored by atul). · Explain WhyNov 13 2023, 2:20 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM00f2222fe0dc: [lib] Introduce `getMinimallyEncodedCurrentUser`.

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

30 lines

Diff 33133

View Options

lib/shared/thread-utils.js

[lib] Introduce `getMinimallyEncodedCurrentUser`ClosedPublicActions