Paths

Table of Contentst

Differential D9847

[lib] Update signatures in `thread-utils` to handle `MinimallyEncodedThreadInfo`
ClosedPublic
Actions

Authored by atul on Nov 13 2023, 2:13 PM.

Tags

None

Referenced Files

	F3246243: D9847.id33173.diff
	Thu, Nov 14, 10:08 PM

	F3246131: D9847.id33174.diff
	Thu, Nov 14, 9:22 PM

	Unknown Object (File)
	Oct 15 2024, 7:35 PM

	Unknown Object (File)
	Oct 15 2024, 1:19 AM

	Unknown Object (File)
	Oct 15 2024, 1:19 AM

	Unknown Object (File)
	Oct 15 2024, 1:19 AM

	Unknown Object (File)
	Oct 15 2024, 1:19 AM

	Unknown Object (File)
	Oct 15 2024, 1:14 AM

View All 61 Files

Subscribers

None

Details

Reviewers

ashoat
ginsu
tomek
rohan

Commits

rCOMM93f4eb08785d: [lib] Update signatures in `thread-utils` to handle `MinimallyEncodedThreadInfo`

Summary

Similar to D9811, we're updating utilities in thread-utils to handle MinimallyEncodedThreadInfo where the change is as simple as updating fn signature.

Will now go through and handle the ones that require more refactoring/branching/etc. Specifically:

threadUIName
checkIfDefaultMembers
patchThreadInfoToIncludeMentionedMembersOfParent
useRoleUserSurfacedPermissions

Depends on D9846

Test Plan

Entirely flow for now.

Diff Detail

Repository

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Nov 13 2023, 2:13 PM

atul added inline comments.Nov 13 2023, 2:15 PM

lib/types/thread-types.js
51–55	Spreading `MemberInfo` causes fields to being "writeable." This became an issue because I wrapped type definition of `MinimallyEncodedRelativeMemberInfo` in `$ReadOnly<>` which caused some `flow` issues. I figure this is more "correct" anyways given we prefer read-only where possible?

atul published this revision for review.Nov 13 2023, 2:15 PM

atul added a child revision: D9848: [lib] Update `threadUIName` to handle `MinimallyEncodedThreadInfo`.Nov 13 2023, 2:29 PM

ashoat accepted this revision.Nov 13 2023, 2:31 PM

This revision is now accepted and ready to land.Nov 13 2023, 2:31 PM

Harbormaster completed remote builds in B24060: Diff 33150.Nov 13 2023, 2:33 PM

rebase and land

This revision was landed with ongoing or failed builds.Nov 13 2023, 3:02 PM

Closed by commit rCOMM93f4eb08785d: [lib] Update signatures in `thread-utils` to handle `MinimallyEncodedThreadInfo` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM93f4eb08785d: [lib] Update signatures in `thread-utils` to handle `MinimallyEncodedThreadInfo`.

Harbormaster completed remote builds in B24075: Diff 33173.Nov 13 2023, 4:46 PM

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

205 lines

types/

thread-types.js

4 lines

Diff 33150

lib/shared/thread-utils.js

Loading...

lib/types/thread-types.js

Loading...