[lib] Update signatures in `thread-utils` to handle `MinimallyEncodedThreadInfo`
ClosedPublic
Actions

Authored by atul on Nov 13 2023, 2:13 PM.

Details

Reviewers

ashoat
ginsu
tomek
rohan

Commits

rCOMM93f4eb08785d: [lib] Update signatures in `thread-utils` to handle `MinimallyEncodedThreadInfo`

Summary

Similar to D9811, we're updating utilities in thread-utils to handle MinimallyEncodedThreadInfo where the change is as simple as updating fn signature.

Will now go through and handle the ones that require more refactoring/branching/etc. Specifically:

threadUIName
checkIfDefaultMembers
patchThreadInfoToIncludeMentionedMembersOfParent
useRoleUserSurfacedPermissions

Depends on D9846

Test Plan

Entirely flow for now.

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D9847 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Nov 13 2023, 2:13 PM

atul added inline comments.Nov 13 2023, 2:15 PM

lib/types/thread-types.js
51–55 ↗	(On Diff #33150)	Spreading `MemberInfo` causes fields to being "writeable." This became an issue because I wrapped type definition of `MinimallyEncodedRelativeMemberInfo` in `$ReadOnly<>` which caused some `flow` issues. I figure this is more "correct" anyways given we prefer read-only where possible?