Page MenuHomePhabricator
Differential D9887

[web] introduce keyservers to the settings switcher
ClosedPublic
Actions

Authored by ginsu on Nov 14 2023, 2:16 PM.
Tags
None
Referenced Files
F3185568: D9887.id33275.diff
Fri, Nov 8, 1:03 PM
F3184772: D9887.id33226.diff
Fri, Nov 8, 11:53 AM
F3184708: D9887.id33277.diff
Fri, Nov 8, 11:38 AM
F3183724: D9887.diff
Fri, Nov 8, 9:56 AM
Unknown Object (File)
Thu, Nov 7, 8:39 AM
Unknown Object (File)
Wed, Nov 6, 2:14 AM
Unknown Object (File)
Tue, Nov 5, 2:13 AM
Unknown Object (File)
Sat, Nov 2, 3:24 PM
View All 62 Files
Subscribers
ashoat
tomek

Details

Reviewers
inka
rohan
michal
Commits
rCOMMc055ddbdb6cb: [web] introduce keyservers to the settings switcher
Summary

This diff introduces a new "Keyservers" option in the settings switcher. This option will be gated behind the staffCanSee flag. Subsequent diffs will implement the keyserver list ui

Here is a screenshot of the figma designs:

Screenshot 2023-11-14 at 5.21.32 PM.png (1×1 px, 170 KB)

Linear task: https://linear.app/comm/issue/ENG-4720/create-new-keyserver-selection-setting-panel-in-the-user-settings

Test Plan

Please see screenshot below

Screenshot 2023-11-14 at 5.17.44 PM.png (1×3 px, 688 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Nov 14 2023, 2:16 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 14 2023, 2:16 PM
ginsu edited the summary of this revision. (Show Details)Nov 14 2023, 2:20 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: inka, rohan, michal.
ginsu attached a referenced file: F876977: Screenshot 2023-11-14 at 5.17.44 PM.png. (Show Details)
ginsu edited the summary of this revision. (Show Details)
ginsu attached a referenced file: F876982: Screenshot 2023-11-14 at 5.21.32 PM.png. (Show Details)
ginsu added a child revision: D9888: [web] introduce status indicator component.Nov 14 2023, 2:26 PM
Harbormaster completed remote builds in B24124: Diff 33226.Nov 14 2023, 2:52 PM
ginsu requested review of this revision.Nov 14 2023, 2:52 PM
rohan accepted this revision.Nov 15 2023, 6:56 AM
This revision is now accepted and ready to land.Nov 15 2023, 6:56 AM
ginsu updated this revision to Diff 33275.Nov 15 2023, 10:35 AM

rebase before landing

This revision was landed with ongoing or failed builds.Nov 15 2023, 10:48 AM
Closed by commit rCOMMc055ddbdb6cb: [web] introduce keyservers to the settings switcher (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMc055ddbdb6cb: [web] introduce keyservers to the settings switcher.
Harbormaster completed remote builds in B24161: Diff 33275.Nov 15 2023, 11:04 AM

Revision Contents
Changeset List

PathSize
lib/
utils/
8 lines
web/
2 lines
navigation-panels/
28 lines
types/
6 lines

Diff 33277

View Options

lib/utils/url-utils.js

Loading...
View Options

web/app.react.js

Loading...
View Options

web/navigation-panels/settings-switcher.react.js

Loading...
View Options

web/types/nav-types.js

Loading...